Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Properly set password when deployed by Argo CD #607

Conversation

yandongxiao
Copy link
Collaborator

Description

see #606

Checklist

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

Signed-off-by: yandongxiao <yandongxiao@starrocks.com>
Copy link
Collaborator

@dengliu dengliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@yandongxiao yandongxiao merged commit bdb1db6 into StarRocks:main Dec 9, 2024
5 checks passed
@dengliu
Copy link
Collaborator

dengliu commented Dec 9, 2024

@yandongxiao can you please cut a new helm chart release to include this fix?
Thank you!

@yandongxiao
Copy link
Collaborator Author

According to the rhythm of releasing new versions approximately every two months, we plan to release a new version at the end of this month. Is it ok?

@dengliu
Copy link
Collaborator

dengliu commented Dec 9, 2024

We can wait till end of this month.
Can we make sure this is also address in this release ?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants