Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the observed events to mouseup, keyup #98

Closed
warpech opened this issue Apr 21, 2016 · 2 comments
Closed

Change the observed events to mouseup, keyup #98

warpech opened this issue Apr 21, 2016 · 2 comments
Assignees
@aloscha

Comments

@warpech
Copy link
Collaborator

warpech commented Apr 21, 2016

JSON-Patch currently observes the following events: mousedown, mouseup, keydown.

For my taste, mousedown and keydown are unpractical.

The list should be changed to have only two events: mouseup, keyup.
@warpech warpech changed the title Change the observed events Change the observed events to mouseup, keyup Apr 21, 2016
@warpech warpech mentioned this issue Apr 21, 2016
Closed
@warpech
Copy link
Collaborator Author

warpech commented May 25, 2016

This is now done in #99. Closing as duplicate

@warpech warpech closed this as completed May 25, 2016
@warpech
Copy link
Collaborator Author

warpech commented May 26, 2016

Reopening as #99 is cancelled

@aloscha aloscha reopened this May 27, 2016
aloscha added a commit that referenced this issue May 27, 2016
@aloscha
Change the observed events to mouseup, keyup #98
81ede07 
Remove slowCheck (dirty checking in fixed time intervals) #103
@aloscha aloscha mentioned this issue May 27, 2016
Merged
aloscha added a commit that referenced this issue May 30, 2016
@aloscha
Fix rv #103 #98
e3afd5b
aloscha added a commit that referenced this issue May 30, 2016
@aloscha
Revert rv #103 #98
565ffa5
aloscha added a commit that referenced this issue May 30, 2016
@aloscha
Merge pull request #104 from Starcounter-Jack/dirty_check_fix_#103_#98
40ff8fb 
Fix json-patch check #103 #98
@aloscha aloscha closed this as completed May 30, 2016
@tomalec tomalec mentioned this issue Sep 5, 2016
Closed
tomalec added a commit that referenced this issue Sep 9, 2016
@tomalec
Restore observing keydown and mousedown events
9240699 
Palindrom/Palindrom/issues/98

Partialy reverts Starcounter-Jack/JSON-Patch/commit/81ede07d94305bbdc53cf449717e7c3f4294cb46 (/issues/98)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aloscha aloscha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warpech @aloscha