Fix problem when observing 2 objects in the same application #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a collision in
beforeDict
that caused all observed objects to use the same lookup key.Only browsers without Object.observe support are affected.
This is because only a string can be a object key. If another type is given, implicit conversion takes place - which may lead to unexpected results:
I am quite surprised TypeScript does not do anything to help to avoid such pitfalls.
Included in this pull request is a fix and test case.