Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2337

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Update README.md #2337

merged 2 commits into from
Jul 7, 2023

Conversation

kn0wmad
Copy link
Contributor

@kn0wmad kn0wmad commented Jul 6, 2023

No description provided.

@kn0wmad kn0wmad requested a review from MattDHill July 6, 2023 17:33
MattDHill
MattDHill reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@MattDHill MattDHill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think many will want to copy/paste the email instead of launching the default email app on their device. So maybe drop the link and just display the address?

@kn0wmad
Copy link
Contributor Author

kn0wmad commented Jul 7, 2023

I think many will want to copy/paste the email instead of launching the default email app on their device. So maybe drop the link and just display the address?

My reasoning here was to obscure the email from a basic text search of the page. You can right-click and copy email addresses. However, I changed to a regular link as requested.

@MattDHill
Copy link
Member

That's a good point and would probably be fine as such. But I'm fine either way, approving.

@kn0wmad kn0wmad merged commit 1d3d70e into master Jul 7, 2023
5 checks passed
@kn0wmad kn0wmad deleted the kn0wmad-patch-1 branch July 7, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattDHill MattDHill MattDHill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kn0wmad @MattDHill