fix: Logging in deno to filter out the info #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-bonez
approved these changes
Oct 31, 2023
Blu-J
force-pushed
the
fix/logging-in-deno-not-filtering
branch
from
df31f78
to
6c80ff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
That during the testing there was found a noise in the logs that seemed to indicate error
Why This solution
The actual solution was to change all the sdk that all the services use to no longer say error in the info.
But the end case is that we are just going to filter up to the warn, and remove the noise in the logs for the services and js.
Proof
2023-10-31.12-15-20.mp4