Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: checkPortListening: check tcp6/udp6 ports #2763

Open
wants to merge 1 commit into
base: next/minor
Choose a base branch
from

Conversation

remcoros
Copy link

@remcoros remcoros commented Oct 22, 2024

ipv6 checks were missing.

This is from the Uptime Kuma container:

root@IMHWWUJCO33JPYQ5DBIF3N3B6PEVJBAE:~# netstat -l
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State
tcp        0      0 localhost:domain        0.0.0.0:*               LISTEN
tcp        0      0 localhost:domain        0.0.0.0:*               LISTEN
tcp        0      0 0.0.0.0:5355            0.0.0.0:*               LISTEN
tcp6       0      0 [::]:3001               [::]:*                  LISTEN
tcp6       0      0 [::]:5355               [::]:*                  LISTEN
udp        0      0 0.0.0.0:5355            0.0.0.0:*
udp        0      0 localhost:domain        0.0.0.0:*
udp        0      0 localhost:domain        0.0.0.0:*
udp        0      0 IMHWWUJCO33JPYQ5:bootpc 0.0.0.0:*
udp6       0      0 [::]:5355               [::]:*
raw6       0      0 [::]:ipv6-icmp          [::]:*

notice that it only listens on a tcp6 port (3001).

Blu-J
Blu-J previously approved these changes Oct 22, 2024
@remcoros remcoros marked this pull request as ready for review October 23, 2024 17:56
@dr-bonez
Copy link
Member

my concern here is that the os does not support ipv6 networking to the containers rn. so a success via this metric would be misleading

@remcoros
Copy link
Author

not sure what's going on then. I packaged uptime kuma and the port healthcheck on 3001 was failing, but I can visit the ui fine and netstat shows only listening on tcp6 [::]:3001, so it does seem to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants