Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode/code-server #337

Closed
Jose-Matsuda opened this issue Apr 5, 2022 · 1 comment · Fixed by #375
Closed

Update vscode/code-server #337

Jose-Matsuda opened this issue Apr 5, 2022 · 1 comment · Fixed by #375
Labels
good-first-issue Good for newcomers size/S ~1 day

Comments

@Jose-Matsuda
Copy link
Contributor

Jose-Matsuda commented Apr 5, 2022

Currently we use a fork here

ARG VSCODE_URL=https://github.com/StatCan/code-server/releases/download/v${VSCODE_VERSION}/code-server_${VSCODE_VERSION}_amd64.deb

I think the reason for this initially was to block the download #281.

There has been action upstream in an issue upstream so maybe we'll be able to switch back at some point

As for remote desktop we do use original vscode and should get around to updating this as well.

In both cases may need to upgrade the French .vsix files for both

Might actually be a size/M but just update if necessary

@Jose-Matsuda Jose-Matsuda changed the title Update vscode/code-server in remote desktop Update vscode/code-server in jupyterlab-xyz Apr 5, 2022
@Jose-Matsuda Jose-Matsuda changed the title Update vscode/code-server in jupyterlab-xyz Update vscode/code-server Apr 5, 2022
@Jose-Matsuda Jose-Matsuda added good-first-issue Good for newcomers size/S ~1 day labels May 17, 2022
@Souheil-Yazji
Copy link
Contributor

Souheil-Yazji commented Aug 4, 2022

It seems that the option to disable download is enabled via a CLI command flag. I'm not sure how code-server is integrated on jupyterlab notebooks and whether or not it's possible to configure the vs code-server launcher. If it is, we may be able to use an env variable to assign a value for the --disable-file-downloads flag depending on the notebook type (pro-b vs unc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers size/S ~1 day
Projects
None yet
2 participants