-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(code-server): change code-server source from forked repo to upstr… #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexingly
reviewed
Aug 24, 2022
vexingly
previously approved these changes
Aug 24, 2022
vexingly
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Image: k8scc01covidacrdev.azurecr.io/jupyterlab-cpu:997b7919ef76c777b7caaafa89cbf8dbd25ff78c |
JaeggerJose
pushed a commit
to wycc/cgu-kubeflow-containers
that referenced
this pull request
Dec 30, 2024
fix(code-server): change code-server source from forked repo to upstr…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Points the Jupyterlab and sas images to the https://github.com/coder/code-server repo instead of the Statcan fork.
Updates code-server from v3.10.2(vs-Code v1.56.1) -> v4.5.1(vs-Code v1.68.1)
Includes feature from upstream to remove the download button in continuity with:
Note
The ability to disable file downloads is done through a cli flag which can be set using an environment variable. I noticed that users can modify environment variables on their jupyterlab notebooks, so I went ahead and tried to modify the variable
CS_DISABLE_FILE_DOWNLOADS = 0
but I still couldn't see the "download" option in vs-code. Double check this during review.Impact
Closes StatCan/aaw#1100
Partially resolves #337
Deprecates https://github.com/StatCan/code-server
Tests / Quality Checks
Automated Testing/build and deployment
auto-deploy
tag to the PR before pushing in order to build and push the image to ACR so you can test it in cluster as a custom image?VS Code tests
Code review
auto-deploy
tag to your PR before your most recent push to this repo? This causes CI to build the image and push to our ACR, letting reviewers access the built image without having to create it themselvesk8scc01covidacrdev.azurecr.io/jupyterlab-cpu:746d058e2f37e004da5ca483d121bfb9e0545f2b
)?