Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code-server): change code-server source from forked repo to upstr… #375

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

Souheil-Yazji
Copy link
Contributor

@Souheil-Yazji Souheil-Yazji commented Aug 8, 2022

Description

Note

The ability to disable file downloads is done through a cli flag which can be set using an environment variable. I noticed that users can modify environment variables on their jupyterlab notebooks, so I went ahead and tried to modify the variable CS_DISABLE_FILE_DOWNLOADS = 0 but I still couldn't see the "download" option in vs-code. Double check this during review.

Impact

Closes StatCan/aaw#1100
Partially resolves #337
Deprecates https://github.com/StatCan/code-server

Tests / Quality Checks

Automated Testing/build and deployment

  • Does the image pass CI successfully (build, pass vulnerability scan, and pass automated test suite)?
  • If new features are added (new image, new binary, etc), have new automated tests been added to cover these?
  • If new features are added that require in-cluster testing (e.g. a new feature that needs to interact with kubernetes), have you added the auto-deploy tag to the PR before pushing in order to build and push the image to ACR so you can test it in cluster as a custom image?

VS Code tests

  • Does VS Code open?
  • Can you install extensions?

Code review

  • Have you added the auto-deploy tag to your PR before your most recent push to this repo? This causes CI to build the image and push to our ACR, letting reviewers access the built image without having to create it themselves
  • Have you chosen a reviewer, attached them as a reviewer to this PR, and messaged them with the SHA-pinned image name for the final image to test on the dev cluster (e.g. k8scc01covidacrdev.azurecr.io/jupyterlab-cpu:746d058e2f37e004da5ca483d121bfb9e0545f2b)?

vexingly
vexingly previously approved these changes Aug 24, 2022
Copy link
Contributor

@vexingly vexingly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Souheil-Yazji
Copy link
Contributor Author

Image: k8scc01covidacrdev.azurecr.io/jupyterlab-cpu:997b7919ef76c777b7caaafa89cbf8dbd25ff78c

@Souheil-Yazji Souheil-Yazji merged commit ab40ab2 into master Sep 6, 2022
@Souheil-Yazji Souheil-Yazji deleted the daaas-1100 branch September 6, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code-server: user settings not persisted Update vscode/code-server
2 participants