Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code-server French translation #387

Closed
Souheil-Yazji opened this issue Aug 24, 2022 · 2 comments · Fixed by #393
Closed

Update code-server French translation #387

Souheil-Yazji opened this issue Aug 24, 2022 · 2 comments · Fixed by #393
Assignees
Labels
size/S ~1 day

Comments

@Souheil-Yazji
Copy link
Contributor

Souheil-Yazji commented Aug 24, 2022

Some french content needs to be updated once #375 is merged in

i.e:
Image

Extra information
#252 (comment)

@Jose-Matsuda Jose-Matsuda self-assigned this Sep 7, 2022
@Jose-Matsuda Jose-Matsuda added the size/S ~1 day label Sep 7, 2022
@Jose-Matsuda
Copy link
Contributor

Jose-Matsuda commented Sep 7, 2022

Note that oddly enough, on prod none of it is in French, and seems to have a later version installed, than what we have
image

@Jose-Matsuda
Copy link
Contributor

Jose-Matsuda commented Sep 7, 2022

Oh the reason for two installations is because we turned off auto-update, note that we had auto-update off initially, I did say ok to this, but didn't look too deep into it hoping that the version update would just fix it, but alas it did not it seems, i will try a few options.

  • Keeping out auto-update, but updating the languagepacks.json --> This, in tandem with also updating the install version pin seemed to fix it
  • bringing back in the auto-update --> unnecessary, but unsure what will happen in the future if it will break it.

Got it to work like this, need to make some changes and will push /test further
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S ~1 day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants