-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: repo build errors and vscode issues #252
Conversation
New vulnerability found: CVE-2021-23334 according to the comments in this issue, it's a false positive and in the process of being revoked. Vulnerability withdrawn GHSA-8v27-2fg9-7h62 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
There's some annoying behaviour happening right now with the French Language extension. It is installed, but vscode is not recognizing it as a "display language" option. Using the older version of the French extension did not work either. I think the reason is the languagepacks.json not getting created properly in the /etc/share/code-server/ directory. To what I get when I try running locally I'll try this out in a bit, as well as maybe make it such that it would use the French file on startup (previously we just installed it and say the LANG variable had no impact on how code-server was starting up) While not helpful right now, the folks at cdr are looking into doing this sort of thing automatically coder/code-server#3173 |
I was going to do a review but I'll hold off on this till Jose reports back :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two suggested comments/changes to comments
Also pushed a change moving the libpdfbox-java uninstall up in the stack. I want CI to build successfully in case I broke something, so I haven't approved yet. Will approve when that is done
docker-bits/0_cpu.Dockerfile
Outdated
# as simply using the tag does not allow stability and reproducibility as these image tags are updated frequently. | ||
# the BASE_VERSION pinned below corresponds to a git commit SHA for image jupyter/datascience-notebook:r-4.0.3 | ||
# Using the git-SHA is unique and immutable. it can be obtained by running `docker inspect repo/imagename:tag@digest` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# as simply using the tag does not allow stability and reproducibility as these image tags are updated frequently. | |
# the BASE_VERSION pinned below corresponds to a git commit SHA for image jupyter/datascience-notebook:r-4.0.3 | |
# Using the git-SHA is unique and immutable. it can be obtained by running `docker inspect repo/imagename:tag@digest` | |
# Docker-stacks version tags (eg: `r-4.0.3`) are LIVE images that are frequently updated. To avoid unexpected | |
# image updates, pin to the docker-stacks git commit SHA tag. | |
# It can be obtained by running `docker inspect repo/imagename:tag@digest` or from | |
# https://github.com/jupyter/docker-stacks/wiki |
20449a4
to
a16f165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
team effort! :D lgtm
Leaving for @JessicaBarh to merge once tests pass. Jess please make sure to squash on merge (I'm terrible at remembering that...) |
9ddaf35
to
9774611
Compare
Description
Resolves #249, #247, #240 also #257
Tests / Quality Checks
Automated Testing/build and deployment
auto-deploy
tag to the PR before pushing in order to build and push the image to ACR so you can test it in cluster as a custom image?JupyterLab extensions
jupyter labextension list
from inside the notebook)?VS Code tests
Code review
auto-deploy
tag to your PR before your most recent push to this repo? This causes CI to build the image and push to our ACR, letting reviewers access the built image without having to create it themselvesk8scc01covidacr.azurecr.io/machine-learning-notebook-cpu:746d058e2f37e004da5ca483d121bfb9e0545f2b
)?