Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to LANG setting for locale #3173

Closed
jawnsy opened this issue Apr 20, 2021 · 4 comments
Closed

Default to LANG setting for locale #3173

jawnsy opened this issue Apr 20, 2021 · 4 comments
Labels
feature New user visible feature
Milestone

Comments

@jawnsy
Copy link
Contributor

jawnsy commented Apr 20, 2021

@oxy explained how code-server's localizations work:

FWIW on code-server's side we have localizations working; all that's needed is F1 -> Configure Display Language -> Install additional languages -> selecting from extensions for manual changes.

This could be something that can be automated on the enterprise side by code-server --install-extension ms-ceintl.vscode-language-pack-fr and then writing {"locale": "fr"} to ~/.local/share/code-server/User/argv.json - though I haven't touched any of the enterprise code so I don't know how possible that would be

(replace fr with two letter language code as applicable)

As an alternative to writing files, it would be nice if we can instead parse the LANG environment variable (e.g. LANG=en_US.utf8) and default to that. The existing behavior should still take priority as users may want to override the locale (e.g. a Spanish-speaking user that uses an English UI, but wants to use Spanish in their editor).

@jawnsy jawnsy added the feature New user visible feature label Apr 20, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Apr 20, 2021
@stale
Copy link

stale bot commented Oct 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Oct 17, 2021
@devarroyofernando
Copy link

I also tried to automate the Portuguese language by installing the extension and setting the locale to no avail. I installed the MS-CEINTL.vscode-language-pack-pt-BR-1.57.2.vsix package and set "locale": "pt-br" in the argv.json file but it doesn't automatically start in the desired language. However, if you install this same package, through the option install extension from vsix file (within the code-server) it works.

Do you have any suggestions or is it a bug?

@stale stale bot removed the stale label Oct 21, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 28, 2021

However, if you install this same package, through the option install extension from vsix file (within the code-server) it works.

Could be an extension bug then. We're working on switching over to Open VSX so it may be fixed after that!

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Apr 27, 2022
@stale stale bot closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New user visible feature
Projects
None yet
Development

No branches or pull requests

3 participants