Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build_push.yaml: deprecate set-output #491

Merged
merged 9 commits into from
Aug 4, 2023
Merged

Update build_push.yaml: deprecate set-output #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe967dc
Update build_push.yaml: deprecate set-output
bryanpaget Jul 26, 2023
c7b839b
Update build_push.yaml: update syntax
bryanpaget Jul 26, 2023
17e8136
Update build_push.yaml: update syntax for interpolation
bryanpaget Jul 27, 2023
578c0e2
Update build_push.yaml: change notebook name variable name
bryanpaget Jul 27, 2023
69f92bd
Update build_push.yaml: update syntax
bryanpaget Jul 27, 2023
e03f255
Update build_push.yaml: update syntax
bryanpaget Jul 27, 2023
6e1add9
Update build_push.yaml: update syntax
bryanpaget Jul 27, 2023
771dd52
update remaining set-output commands
bryanpaget Jul 27, 2023
8dfd920
Update Makefile: reset set-output commands for Makefile
bryanpaget Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build_push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
id: notebook-name
shell: bash
run: |
echo ::set-output name=NOTEBOOK_NAME::${{ matrix.notebook }}
echo NOTEBOOK_NAME=${{ matrix.notebook }} >> $GITHUB_OUTPUT

# Connect to Azure Container registry (ACR)
- uses: azure/docker-login@v1
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
github.event_name == 'pull_request' &&
contains( github.event.pull_request.labels.*.name, 'auto-deploy')
)
run: echo "::set-output name=boolean::true"
run: echo 'boolean=true' >> $GITHUB_OUTPUT

# Pull the local image back, then "build" it (will just tag the pulled image)
- name: Pull image back from local repo
Expand Down
1 change: 0 additions & 1 deletion make_helpers/get_branch_name.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ if [[ $GITHUB_ACTIONS == "true" ]] ; then
BRANCH_NAME=""
fi

# echo "::set-output name=branch_name::$BRANCH_NAME"
else
BRANCH_NAME=`git rev-parse --abbrev-ref HEAD`
fi
Expand Down