Update base image to 22.04 #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The light-locker removal command was failing, as light-locker was not installed... so I removed the removal command but when I launch the container on Kubeflow... the screen is locked.
the screen is still locking. :-/
the screen is still locking. :-/
Test PSPP from Ubuntu Repo to make sure French UI is shown. Remove installer script and update Dockerfile.
|
The updated 22.04 images build and run locally but I'm having difficulties with the Github Actions runner. |
2 tasks
update actions/setup-python@v2 to actions/setup-python@v4
* Update build_push.yaml: deprecate set-output update workflow to use $GITHUB_OUTPUT instead of set-output. See: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ * Update build_push.yaml: update syntax * Update build_push.yaml: update syntax for interpolation * Update build_push.yaml: change notebook name variable name * update remaining set-output commands * Update Makefile: reset set-output commands for Makefile Github Actions was complaining about set-output in the Makefile but I think we have to leave these lines alone since they are used by Make and not by Github Actions.
2 tasks
|
RStudio does not launch. |
|
I may have installed incompatible versions of rstudio and rstudio-server. |
The previously set location no longer exists.
I've updated rstudio-server to a (hopefully) compatible version.
Updating the |
I found a slightly newer version of |
|
I've fixed the above two issues, but there is still one issue: A "null" error upon opening rstudio-desktop: |
|
R seems to function correctly and it's even running R 4.3.1! But I can't install any packages:
|
bryanpaget
commented
Sep 18, 2023
TestingJupyterLab CPUJupyterLab CPU has an issue with some jupyter plugins, maybe I need to run jupyter lab build somewhere?
This message also comes up.
The above errors don't seem to cause any problems with using the image. RStudioRStudio works but still struggles with
Remote DesktopRemote Desktop works as it should as far as I can tell.
SASEverything seems to work. |
Fix issue with JupyterLab extensions
Tidymodels is a troublesome package, will leave to the user to install, if needed.
I was getting errors saying xxx extension needs to be included in build.
I was getting errors saying xxx extension needs to be included in build.
I was getting errors saying xxx extension needs to be included in build.
I reworked the package install script to use fewer RUN blocks. I also discovered jupyter_contrib_nbextensions prefers pip over mamba. Local testing suggests I've stopped the jupyterlab build errors.
I added pillow and pyyaml to the exclude list since they are not imported by name (e.g. import pil, import yaml).
The issues with JupyterLab have been resolved by cleaning up the JupyterLab extension installation code and calling jupyter lab build in the appropriate place. |
* update(pytorch): remove virtual env * update(pytorch): remove virtual env * update(cpu, pytorch): mamba install pytorch to base * update(pytorch): adjust torch installation * update(pytorch): add ipykernel and conda env * update(pytorch): remove CUDA The PyTorch install command includes CUDA drivers, so I'll try installing those instead of our custom install script. * update(pytorch): add ipykernel * update(pytorch): add gputil gputil has nvidia-smi * update(tensorflow): add cuda to mamba command I also tweaked the pytorch image to use mamba for the clean command * update(tensorflow): add cuda to mamba command I also tweaked the pytorch image to use mamba for the clean command * update(tensorflow): remove tensorflow-gpu tensorflow works for both gpu and cpu * update(gpu-notebooks): remove conda env tensorflow tests are failing, I think they expect tensorflow to be installed in the base env, which is what I prefer, so I'll move pytorch into the base env as well. * update(cpu, pytorch, tensorflow): consistency * update(test_tensorflow): use tensorflow env * update(test_packages): add gputil to exclude list * update(test_packages): add cudnn, cudatoolkit to exclude list * update(pytorch, tensorflow): ipykernel install * revert(cpu): fix cpu conda env * update(tests): gpu available * update(makefile): restore tensorflow build * update(tests): remove GPU test Github Actions won't have a GPU * update(jupyterlab): jupyter-dash caused build fail so I tried removing the version pinning, it wasn't breaking before so I'm not sure what changed. * update(PR): based on comments * update(rstudio): remove pin on tidymodels since it breaks on the newer versions of R but we don't have a consistent version of R across images so it might be helpful to unpin tidymodels so we can let the system resolve a compatible version. * update(get-nvidia-stuff): 1804 to 2204 * revert(2_tensorflow): prev working configuration * update(0_Rocker): remove whitespace delta * update(2_tensorflow): new line * Update test_tensorflow.py: revert test We are not yet using a Tensorflow conda env. --------- Co-authored-by: Bryan Paget <bryan.paget@statcan.gc.ca>
* feat: install openmpp as jupyterlab service * fix: generate dockerfiles * chore: trigger auto-deploy * fix: copy oms startup script * fix: copy script in correct docker bit * fix: make script executable * fix: update openm version, fix config * fix: sync issue * fix: prepare openmpp config for prod deployment * fix: move config to start-oms script
* feat: install openmpp as jupyterlab service * fix: generate dockerfiles * chore: trigger auto-deploy * fix: copy oms startup script * fix: copy script in correct docker bit * fix: make script executable * fix: update openm version, fix config * fix: sync issue * fix: prepare openmpp config for prod deployment * fix: move config to start-oms script Co-authored-by: Pat Ledgerwood <32804494+vexingly@users.noreply.github.com>
* feat: install openmpp as jupyterlab service * fix: generate dockerfiles * chore: trigger auto-deploy * fix: copy oms startup script * fix: copy script in correct docker bit * fix: make script executable * fix: update openm version, fix config * fix: sync issue * fix: prepare openmpp config for prod deployment * fix: move config to start-oms script Co-authored-by: Pat Ledgerwood <32804494+vexingly@users.noreply.github.com>
npm build ompp-ui was failing, adding --openssl-legacy-provider to the build command resolved the issue.
npm build ompp-ui was failing, adding --openssl-legacy-provider to the build command resolved the issue locally but breaks on Github Actions, will try ARG NODE_OPTIONS=--openssl-legacy-provider.
Jose-Matsuda
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the commit to properly close: StatCan/aaw#1784 with pull request: #492 (already reviewed up to this point by @vexingly.
closes StatCan/aaw#1784
Testing and Resolving Issues
light-lockernot being installed was false. I still had to uninstalllight-locker.zlib1gandzlib1g-dev.gvfs-binwithgvfs.RStudio Desktopfrom 1.3.1093 to 2023.06.1-524./usr/share/applications/exo-mail-reader.desktopsince this.desktopfile is no longer included in Ubuntu 22.04.ml-metadataand Python 3.10 but I was able to install and import the module on my VM which uses Python 3.10.Unresolved
TODO
For more details, see: StatCan/aaw#1784.