feat: Add block proB pod unless authpolicy present #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If classification not provided assumed unclassified
|
Updated the PR to be specifically about protected-b classification label since
|
zachomedia
suggested changes
Jul 21, 2021
|
@zachomedia Are you able to re-review? |
|
I rebased this and pushed to master :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
Assumptions:
The pod inherits the
notebook-nameand classification labels.The authorization policy is
{NOTEBOOK_NAME}-protected-b-blockThis blocks all the pods that are not unclassified. Not only the protected-b ones.
And it applies to all notebooks, it is not restricted to rstudio images since it is hard to detect which image it is.
The Authorization Policy will only be blocking certain URLs which are specific to rstudio.
cc @zachomedia