Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to image_name in notebook server creation to prevent or strip leading "http[s]://" #59

Closed
ca-scribner opened this issue Mar 3, 2021 · 0 comments · Fixed by #61

Comments

@ca-scribner
Copy link
Contributor

When creating a notebook server you can enter an image name that has a leading http[s]://, but this will never work (the name used here is a docker image, eg: [repo/]imagename:tag). The frontend can validate this input and do one of:

  • strip leading http[s]:// from any image name without the user knowing it had to be done (preferable unless there's a use case that ever needs the leading http)
  • warn the user when filling out he form (or reject outright) that http is not accepted (do this if we don't think we can just safely always strip)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants