Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add url validation for custom images #61

Merged
merged 1 commit into from
May 21, 2021
Merged

fix: add url validation for custom images #61

merged 1 commit into from
May 21, 2021

Conversation

jumana-s
Copy link
Contributor

Resolves #59

@jumana-s jumana-s requested a review from wg102 May 19, 2021 20:52
@jumana-s jumana-s changed the title add url vallidation for custom images add url validation for custom images May 19, 2021
@jumana-s jumana-s changed the title add url validation for custom images fix: add url validation for custom images May 19, 2021
wg102
wg102 requested changes May 19, 2021
View reviewed changes
Copy link
Contributor

@wg102 wg102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DS_Store file is something specific to MacOS, and should not be added to the project.

frontend/src/app/resource-form/form-image/form-image.component.ts Outdated Show resolved Hide resolved
frontend/src/app/resource-form/form-image/form-image.component.ts Outdated Show resolved Hide resolved
frontend/src/app/resource-form/form-image/form-image.component.ts Outdated Show resolved Hide resolved
frontend/src/app/resource-form/form-image/form-image.component.ts Outdated Show resolved Hide resolved
frontend/src/app/resource-form/form-image/form-image.component.ts Outdated Show resolved Hide resolved
frontend/src/app/resource-form/form-image/form-image.component.ts Outdated Show resolved Hide resolved
frontend/src/app/resource-form/form-image/form-image.component.ts Outdated Show resolved Hide resolved
frontend/src/app/resource-form/form-image/form-image.component.ts Outdated Show resolved Hide resolved
frontend/src/app/resource-form/form-image/form-image.component.ts Outdated Show resolved Hide resolved
@jumana-s jumana-s requested a review from wg102 May 20, 2021 14:01
@jumana-s jumana-s force-pushed the 59-add-custom-image-url-validation branch from 4c6fb31 to 4e2554f Compare May 20, 2021 20:26
@wg102 wg102 merged commit 416bcb1 into master May 21, 2021
@wg102 wg102 deleted the 59-add-custom-image-url-validation branch May 21, 2021 13:42
@jumana-s jumana-s mentioned this pull request May 21, 2021
Merged
@wg102 wg102 mentioned this pull request Sep 12, 2022
Closed
15 tasks
@mathis-marcotte mathis-marcotte mentioned this pull request Sep 21, 2022
Closed
Jose-Matsuda added a commit that referenced this pull request Sep 22, 2022
@Jose-Matsuda
Salwa #61
2244af6
@Jose-Matsuda Jose-Matsuda mentioned this pull request Sep 22, 2022
Merged
Jose-Matsuda added a commit that referenced this pull request Oct 3, 2022
@Jose-Matsuda
Validation fix (#144)
f72afcd 
* This adds back our custom changes introduced in #19, #51, #61. All changes have been noted with some comments to make this easier when we do it again next time.

* PLEASE NOTE. There are NO translations and there is test text. 

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wg102 wg102 wg102 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation to image_name in notebook server creation to prevent or strip leading "http[s]://"
2 participants
@jumana-s @wg102