Validation fix #144
Merged
Validation fix #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/StatCan/jupyter-apis/pull/51/files I think this is good, would want to confirm im a bit unsure
Jose-Matsuda
commented
Sep 23, 2022
| @@ -47,7 +47,7 @@ export class NamespaceService { | |||
| this.dashboardConnectedSource.next(DashboardState.Disconnected); | |||
|
|
|||
| if (this.currNamespace === undefined) { | |||
| this.updateSelectedNamespace('kubeflow-user'); | |||
| this.updateSelectedNamespace('jose-matsuda'); | |||
There was a problem hiding this comment.
Dont forget to change this back to kubeflow-user
|
I noticed this error appearing in the browser console(tested on firefox) when you open the form(hitting the New notebook button)
|
mathis-marcotte
approved these changes
Sep 29, 2022
Closed
Jose-Matsuda
added a commit
that referenced
this pull request
Nov 3, 2022
* feat(frontend): upgrade frontend to 1.6 bringing in customizations * feat(translations): for 1.6, PRs (#166), (#183) * fix(angular translations): (#161) * feat(folder structure): changed folder structure to match 1.6 * chore(unwanted code): commented out unwanted features, removed dead code * feat(hint text): added back * feat(tables): add volume table (#145), add kubecost table (#149) * feat(sas): add SAS functionality back (#147) * fix(various): image pull policy fix (#151), validation (#144), volumes (#164) * fix(system language, limits): added back system language input (#150), modify limits (#152) * feat(Taskfile.yaml): update go:build task * fix(sc): added missing api endpoint for storage classes * refactor(Dockerfile): bind API to new port, change copy paths * fix(frontend): icon paths, svg paths, env path to logo svgs and added * fix(backend):update to handle new frontend structure * fix(failing build): (#169) * fix(volume name): update formCtrl.get() (#174) * feat(pro-b):added Pro b icon to notebook and volume table (#179) * fix(default language):language context set to system language input (#180) Co-authored-by: Wendy V Gaultier <wendyvgaultier@gmail.com> Co-authored-by: Bryan Paget <bryan.paget@statcan.gc.ca> Co-authored-by: Rohan Katkar <rohank_17@hotmail.ca> Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> Co-authored-by: Jose Manuel (Ito) <jose.matsuda@statcan.gc.ca> Co-authored-by: Wendy Gaultier <wendy.gaultier2@canada.ca> Co-authored-by: Jose-Matsuda <jose.matsuda@canada.ca> Co-authored-by: Collin Brown <collin.j.brown95@gmail.com> Co-authored-by: Collin Brown <Collinbrown95@gmail.com> Co-authored-by: Bryan Paget <bbrryyaann@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LAST THING TO DO IS TRANSLATIONS (probably not in this PR)
Closes #138
Note that AAW specific changes are tagged with a comment saying AAW