Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6 fix volumes #164

Merged
merged 8 commits into from
Oct 18, 2022
Merged

1.6 fix volumes #164

merged 8 commits into from
Oct 18, 2022

Conversation

Jose-Matsuda
Copy link
Contributor

@Jose-Matsuda Jose-Matsuda commented Oct 12, 2022

Fix volumes let people submit their workload requests

closes #158

@Jose-Matsuda Jose-Matsuda linked an issue Oct 13, 2022 that may be closed by this pull request
@Jose-Matsuda Jose-Matsuda marked this pull request as ready for review October 13, 2022 17:09
@mathis-marcotte
Copy link
Contributor

Im seeing this error in the browser console, would it be something related to this issue because it mentions volumes?
image

@mathis-marcotte
Copy link
Contributor

With the data volumes, I've noticed a few things. So when you add a data volume, firstly with the name of the data volume the name gets generated as "[object Object]-datavol-1" instead of using the name of the notebook. Second, and this one is happening on both data and workspace volumes, in that info line next to the "New Volume" it defaults with the value 16Gi, but when you open the volume information, that "Size in Gi" input is empty. Lastly, when I add a data volume, even if I fill things in the form, the launch button at the end stays disabled.
image

@Jose-Matsuda
Copy link
Contributor Author

Jose-Matsuda commented Oct 17, 2022

I have made very little progress on this, made some print statements in the name.component.ts to find the following, which honestly is something we already know...

image
and a screencap of other things
image

This was referenced Oct 18, 2022
@Jose-Matsuda Jose-Matsuda merged commit 37df279 into upgrade-frontend-1.6 Oct 18, 2022
@wg102 wg102 deleted the 1.6-fix-volumes branch October 26, 2022 14:09
Jose-Matsuda added a commit that referenced this pull request Nov 3, 2022
* feat(frontend): upgrade frontend to 1.6 bringing in customizations

* feat(translations): for 1.6, PRs (#166), (#183) 

* fix(angular translations): (#161)

* feat(folder structure): changed folder structure to match 1.6

* chore(unwanted code): commented out unwanted features, removed dead code

* feat(hint text): added back 

* feat(tables): add volume table (#145), add kubecost table (#149)

* feat(sas): add SAS functionality back (#147)

* fix(various): image pull policy fix (#151), validation (#144), volumes (#164)

* fix(system language, limits): added back system language input (#150), modify limits (#152)

* feat(Taskfile.yaml): update go:build task

* fix(sc): added missing api endpoint for storage classes

* refactor(Dockerfile): bind API to new port, change copy paths

* fix(frontend): icon paths, svg paths, env path to logo svgs and added

* fix(backend):update to handle new frontend structure

* fix(failing build): (#169)

* fix(volume name): update formCtrl.get() (#174)

* feat(pro-b):added Pro b icon to notebook and volume table (#179)

* fix(default language):language context set to system language input (#180)


Co-authored-by: Wendy V Gaultier <wendyvgaultier@gmail.com>
Co-authored-by: Bryan Paget <bryan.paget@statcan.gc.ca>
Co-authored-by: Rohan Katkar <rohank_17@hotmail.ca>
Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
Co-authored-by: Jose Manuel (Ito) <jose.matsuda@statcan.gc.ca>
Co-authored-by: Wendy Gaultier <wendy.gaultier2@canada.ca>
Co-authored-by: Jose-Matsuda <jose.matsuda@canada.ca>
Co-authored-by: Collin Brown <collin.j.brown95@gmail.com>
Co-authored-by: Collin Brown <Collinbrown95@gmail.com>
Co-authored-by: Bryan Paget <bbrryyaann@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.6: Fix volumes
2 participants