Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n angular #161

Merged
merged 12 commits into from
Oct 5, 2022
Merged

Fix i18n angular #161

merged 12 commits into from
Oct 5, 2022

Conversation

wg102
Copy link
Contributor

@wg102 wg102 commented Oct 5, 2022

Part of #133

Copy link
Contributor

@Collinbrown95 Collinbrown95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wg102 wg102 merged commit bb864fc into upgrade-frontend-1.6 Oct 5, 2022
@wg102 wg102 deleted the fix-i18n-angular branch October 5, 2022 18:41
Jose-Matsuda added a commit that referenced this pull request Nov 3, 2022
* feat(frontend): upgrade frontend to 1.6 bringing in customizations

* feat(translations): for 1.6, PRs (#166), (#183) 

* fix(angular translations): (#161)

* feat(folder structure): changed folder structure to match 1.6

* chore(unwanted code): commented out unwanted features, removed dead code

* feat(hint text): added back 

* feat(tables): add volume table (#145), add kubecost table (#149)

* feat(sas): add SAS functionality back (#147)

* fix(various): image pull policy fix (#151), validation (#144), volumes (#164)

* fix(system language, limits): added back system language input (#150), modify limits (#152)

* feat(Taskfile.yaml): update go:build task

* fix(sc): added missing api endpoint for storage classes

* refactor(Dockerfile): bind API to new port, change copy paths

* fix(frontend): icon paths, svg paths, env path to logo svgs and added

* fix(backend):update to handle new frontend structure

* fix(failing build): (#169)

* fix(volume name): update formCtrl.get() (#174)

* feat(pro-b):added Pro b icon to notebook and volume table (#179)

* fix(default language):language context set to system language input (#180)


Co-authored-by: Wendy V Gaultier <wendyvgaultier@gmail.com>
Co-authored-by: Bryan Paget <bryan.paget@statcan.gc.ca>
Co-authored-by: Rohan Katkar <rohank_17@hotmail.ca>
Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
Co-authored-by: Jose Manuel (Ito) <jose.matsuda@statcan.gc.ca>
Co-authored-by: Wendy Gaultier <wendy.gaultier2@canada.ca>
Co-authored-by: Jose-Matsuda <jose.matsuda@canada.ca>
Co-authored-by: Collin Brown <collin.j.brown95@gmail.com>
Co-authored-by: Collin Brown <Collinbrown95@gmail.com>
Co-authored-by: Bryan Paget <bbrryyaann@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants