Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation fix #144

Merged
merged 20 commits into from
Oct 3, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18,932 changes: 18,921 additions & 11 deletions frontend/common/kubeflow-common-lib/package-lock.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
<lib-icon *ngIf="icon" [icon]="icon"></lib-icon>{{ title }}
</div>
<p>{{ text }}</p>
<!--our changes, for selecting a custom image-->
<a href="{{ link }}" target="_blank" style="text-decoration: none">
{{ linkText }}
</a>
<!--need to check if this change messes with the other things, else just restore old file-->
<p *ngIf="readOnly">*The cluster admin has disabled setting this section!</p>

<ng-content></ng-content>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ export class FormSectionComponent implements OnInit {
@Input()
icon: string;

@Input()
link: string;

@Input()
linkText: string;

constructor() {}

ngOnInit() {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class NamespaceService {
this.dashboardConnectedSource.next(DashboardState.Disconnected);

if (this.currNamespace === undefined) {
this.updateSelectedNamespace('kubeflow-user');
this.updateSelectedNamespace('jose-matsuda');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont forget to change this back to kubeflow-user

}
});
}
Expand Down
Loading