Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cost estimate table #27

Merged
merged 2 commits into from
Oct 21, 2020
Merged

feat: add cost estimate table #27

merged 2 commits into from
Oct 21, 2020

Conversation

saffaalvi
Copy link
Contributor

Resolves #25

@brendangadd brendangadd marked this pull request as draft October 7, 2020 19:24
@saffaalvi saffaalvi force-pushed the kubecost-estimates branch 2 times, most recently from 437092a to 856cb11 Compare October 13, 2020 19:53
@saffaalvi saffaalvi marked this pull request as ready for review October 14, 2020 19:32
@saffaalvi saffaalvi requested a review from brendangadd October 14, 2020 19:33
brendangadd
brendangadd suggested changes Oct 15, 2020
View reviewed changes
frontend/src/app/main-table/cost-table/cost-table.component.ts Outdated Show resolved Hide resolved
frontend/src/app/main-table/resource-table/resource-table.component.ts Outdated Show resolved Hide resolved
namespacecost.go Outdated Show resolved Hide resolved
namespacecost.go Outdated Show resolved Hide resolved
frontend/src/app/main-table/cost-table/cost-table.component.ts Outdated Show resolved Hide resolved
@saffaalvi saffaalvi requested a review from brendangadd October 16, 2020 18:22
@saffaalvi saffaalvi force-pushed the kubecost-estimates branch 3 times, most recently from bce450e to 90125d8 Compare October 16, 2020 19:11
@saffaalvi saffaalvi mentioned this pull request Oct 16, 2020
Closed
zachomedia
zachomedia reviewed Oct 19, 2020
View reviewed changes
namespacecost.go Outdated Show resolved Hide resolved
brendangadd
brendangadd approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@brendangadd brendangadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious!

@brendangadd brendangadd merged commit 49dea69 into master Oct 21, 2020
@brendangadd brendangadd deleted the kubecost-estimates branch October 21, 2020 22:27
saffaalvi pushed a commit that referenced this pull request Feb 11, 2021
@brendangadd
Merge pull request #27 from StatCan/kubecost-estimates
d31ce23 
feat: add cost estimate table
@wg102 wg102 mentioned this pull request Sep 12, 2022
Closed
15 tasks
@mathis-marcotte mathis-marcotte mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachomedia zachomedia zachomedia left review comments

@brendangadd brendangadd brendangadd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display cost estimates for namespace
3 participants
@saffaalvi @zachomedia @brendangadd