Fix the TFJobs Dashboard UI (kubeflow#1717)

* Fix the TFJobs Dashboard UI

* The UI isn't able to list jobs in all namespaces because the
  cluster role binding isn't using the correct role

Related to kubeflow/trainer#836

* Fix test.

.gitignore

@@ -39,3 +39,7 @@ examples/.ipynb_checkpoints/
 
 
 !testing/test-infra/vendor
+
+# This is required for testing but we don't
+# want to check it in right now.
+components/gcp-click-to-deploy/src/user_config/**

kubeflow/core/tests/tf-job_test.jsonnet

@@ -521,3 +521,31 @@ std.assertEqual(
     ],
   }
 )
+
+&&
+
+std.assertEqual(
+  tfjobv1alpha1.tfUiRoleBinding,
+  {
+    apiVersion: "rbac.authorization.k8s.io/v1beta1",
+    kind: "ClusterRoleBinding",
+    metadata: {
+      labels: {
+        app: "tf-job-dashboard",
+      },
+      name: "tf-job-dashboard",
+    },
+    roleRef: {
+      apiGroup: "rbac.authorization.k8s.io",
+      kind: "ClusterRole",
+      name: "tf-job-dashboard",
+    },
+    subjects: [
+      {
+        kind: "ServiceAccount",
+        name: "tf-job-dashboard",
+        namespace: "test-kf-001",
+      },
+    ],
+  }
+)

kubeflow/core/tf-job-operator.libsonnet

@@ -486,9 +486,9 @@
       },
       subjects: [
         {
-          kind: tfServiceAccount.kind,
-          name: tfServiceAccount.metadata.name,
-          namespace: tfServiceAccount.metadata.namespace,
+          kind: tfUiServiceAccount.kind,
+          name: tfUiServiceAccount.metadata.name,
+          namespace: tfUiServiceAccount.metadata.namespace,
         },
       ],
     },