Export ThriftRequestError and fix tests. (#13)

In #9 we changed thrift-client to return an instance of ThriftRequestError when the client gets an HTTP error. This commit exports the ThriftRequestError class and fixes some test assertions in light of those changes.

I feel good about it!

packages/thrift-client/src/main/index.ts

@@ -1,2 +1,3 @@
 export * from './connections'
+export * from './errors'
 export * from './types'

packages/thrift-integration/src/client/connections/HttpConnection.spec.ts

@@ -10,6 +10,7 @@ import {
   IThriftRequest,
   NextFunction,
   RequestOptions,
+  ThriftRequestError,
 } from '@statestitle/thrift-client'
 import { ThriftClientTTwitterFilter, TTwitter } from '@statestitle/thrift-client-ttwitter-filter'
 import * as thrift from '@statestitle/thrift-server-core'
@@ -136,8 +137,12 @@ describe('HttpConnection', () => {
         () => {
           throw new Error('Should reject with status 500')
         },
-        (err: Response) => {
-          expect(err.status).to.equal(500)
+        (err: ThriftRequestError) => {
+          expect(err).to.be.an.error(
+            ThriftRequestError,
+            'Thrift request failed: HTTP 500 Internal Server Error: NOPE'
+          )
+          expect(err.response?.status).to.equal(500)
         }
       )
     })
@@ -155,8 +160,12 @@ describe('HttpConnection', () => {
         () => {
           throw new Error('Should reject with status 400')
         },
-        (err: Response) => {
-          expect(err.status).to.equal(400)
+        (err: ThriftRequestError) => {
+          expect(err).to.be.an.error(
+            ThriftRequestError,
+            'Thrift request failed: HTTP 400 Bad Request: NOPE'
+          )
+          expect(err.response?.status).to.equal(400)
         }
       )
     })

packages/thrift-integration/src/client/connections/index.spec.ts

@@ -10,6 +10,7 @@ import {
   IThriftRequest,
   NextFunction,
   RequestOptions,
+  ThriftRequestError,
 } from '@statestitle/thrift-client'
 import { Int64, readThriftMethod } from '@statestitle/thrift-server-core'
 
@@ -256,8 +257,12 @@ describe('createHttpClient', () => {
         () => {
           throw new Error('Should reject with status 500')
         },
-        (err: Response) => {
-          expect(err.status).to.equal(500)
+        (err: ThriftRequestError) => {
+          expect(err).to.be.an.error(
+            ThriftRequestError,
+            'Thrift request failed: HTTP 500 Internal Server Error: NOPE'
+          )
+          expect(err.response?.status).to.equal(500)
         }
       )
     })
@@ -273,8 +278,12 @@ describe('createHttpClient', () => {
         () => {
           throw new Error('Should reject with status 400')
         },
-        (err: Response) => {
-          expect(err.status).to.equal(400)
+        (err: ThriftRequestError) => {
+          expect(err).to.be.an.error(
+            ThriftRequestError,
+            'Thrift request failed: HTTP 400 Bad Request: NOPE'
+          )
+          expect(err.response?.status).to.equal(400)
         }
       )
     })
@@ -461,8 +470,12 @@ describe('createHttpClient', () => {
         () => {
           throw new Error('Should reject with status 500')
         },
-        (err: Response) => {
-          expect(err.status).to.equal(500)
+        (err: ThriftRequestError) => {
+          expect(err).to.be.an.error(
+            ThriftRequestError,
+            'Thrift request failed: HTTP 500 Internal Server Error: NOPE'
+          )
+          expect(err.response?.status).to.equal(500)
         }
       )
     })
@@ -478,8 +491,12 @@ describe('createHttpClient', () => {
         () => {
           throw new Error('Should reject with status 400')
         },
-        (err: Response) => {
-          expect(err.status).to.equal(400)
+        (err: ThriftRequestError) => {
+          expect(err).to.be.an.error(
+            ThriftRequestError,
+            'Thrift request failed: HTTP 400 Bad Request: NOPE'
+          )
+          expect(err.response?.status).to.equal(400)
         }
       )
     })