Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Change TTL #682

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

JuanJoseGonGi
Copy link

Change TTL

This plugin changes the default ipv4 and ipv6 TTL to the user specified one using sysctl commands.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove debug flag from your plugin.json. I would also like to know why this plugin requires root to perform it's function which can be done without root access via KDE desktop.

@JuanJoseGonGi JuanJoseGonGi changed the title Add Change TTL v1.0.1 Add Change TTL Sep 5, 2024
@JuanJoseGonGi
Copy link
Author

why this plugin requires root to perform it's function which can be done without root access via KDE desktop.

AFAIK to change the TTL using sysctl you need root and in the tests I did it is so. I can't find in the KDE settings a related configuration. Can you please share what method could be used without root?

@TrainDoctor
Copy link
Member

why this plugin requires root to perform it's function which can be done without root access via KDE desktop.

AFAIK to change the TTL using sysctl you need root and in the tests I did it is so. I can't find in the KDE settings a related configuration. Can you please share what method could be used without root?

Apologies, I misunderstood what was meant by TTL and the access levels needed to modify it. What would be the purpose of modifying the TTL for Steam Deck users? (The plugin can go forward now but I'm just curious 😅)

@TrainDoctor TrainDoctor requested review from a team September 5, 2024 17:42
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for testing store.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanJoseGonGi please fix your addition to .gitmodules and bring the branch field properly inline with the other fields. I should have caught that from the start. Please also re-add a screenshot URL and a relevant image.

@TrainDoctor TrainDoctor added the needsfix An issue/change request needs to be resolved label Sep 5, 2024
@JuanJoseGonGi
Copy link
Author

What would be the purpose of modifying the TTL for Steam Deck users

I personally use it to bypass mobile hotspot limits on data plans. I think it could be the main use case for deck

@JuanJoseGonGi
Copy link
Author

Please also re-add a screenshot URL and a relevant image.

@TrainDoctor These 2 refer to the image field on the plugin.json?

@TrainDoctor
Copy link
Member

Please also re-add a screenshot URL and a relevant image.

@TrainDoctor These 2 refer to the image field on the plugin.json?

Yes, that's correct.

@TrainDoctor TrainDoctor removed the needsfix An issue/change request needs to be resolved label Sep 5, 2024
@TrainDoctor TrainDoctor requested a review from a team September 5, 2024 22:18
@TrainDoctor TrainDoctor requested a review from a team September 5, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Ready for review
Development

Successfully merging this pull request may close these issues.

3 participants