Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Chrono-Deck" plugin #688

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add "Chrono-Deck" plugin #688

wants to merge 6 commits into from

Conversation

ynhhoJ
Copy link

@ynhhoJ ynhhoJ commented Sep 5, 2024

ChronoDeck

Brings metadata for Emulated games to achieve a better native experience to the end user.

To do that I collected information about games for platforms: PS1, PS2, PSP, Nintendo3DS, NintendoDS, SNES and GameCube using Wikipedia.

Sheet with entire list of Games: https://docs.google.com/spreadsheets/d/1lF2zJN4S7Ktu8xaLgyymWm9I8kMW7ts2rR6cVj3ZmEA/edit

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Exists MetaDeck but it is not usable at the moment, and there is no ETA when plugin will start work again.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

@ynhhoJ ynhhoJ requested a review from a team as a code owner September 5, 2024 14:57
@TrainDoctor
Copy link
Member

@AAGaming00 will need you to do the review on this one as there is so much typescript etc that I don't feel properly equipped to review this one.

@TrainDoctor TrainDoctor removed the needsfix An issue/change request needs to be resolved label Sep 5, 2024
@ynhhoJ
Copy link
Author

ynhhoJ commented Sep 13, 2024

Rebased branch to the latest changes from main branch of decky-plugin-database repository.

beebls
beebls approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@beebls beebls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS Side looks GTM, ready for testing

@ynhhoJ
Copy link
Author

ynhhoJ commented Sep 14, 2024

@beebls , just pushed an update to minimize bandwidth consumption.

Can you review when you are free, please?

@ynhhoJ ynhhoJ requested a review from beebls September 14, 2024 10:23
@ynhhoJ
Copy link
Author

ynhhoJ commented Sep 20, 2024

@TrainDoctor , can you please checkout last modifications, when you are free?

Thanks!

P.S: I added some socials links to get better user feedback.

@ynhhoJ
Copy link
Author

ynhhoJ commented Oct 3, 2024

New review needed 🙏

@TrainDoctor
Copy link
Member

TrainDoctor commented Oct 13, 2024 •
edited
Loading

@ynhhoJ please include the original plugin license from the plugin template at the bottom of your own license file and then we're good. That got missed in the first reviews and that's on me. Once that's done and a testing report is file we're good to merge to production.

@ynhhoJ
Add "Chrono-Deck" plugin
90be36c
@ynhhoJ
Implemented local save of games metadata
66261e4 
- Allow user to locally edit games metdata
- Implemented `syncIntervalDays` for users who does want to update
metadata daily
- Add "Force Sync" button
- Code refactoring
- Upgrade version to v0.1.0
@ynhhoJ
Minimize bandwidth consume by detect non-supported platforms before i…
54bfdec 
…s send any requests to API

- feat: Detect PS2 platform by ROM folder
- perf: Prevent searching games for unsupported platforms
- test: Utils: getMinValidSyncInterval: Add more test cases
- Upgrade version to 0.1.1
- chore: Updated plugin description
@ynhhoJ
Add links & more detailed information about what buttons do in Quick …
f284f44 
…Access Panel
@ynhhoJ
Implement better filtering support by "Last Time Played", "Date added…
727583c 
… to library", "Size on Disk"

- chore(dependencies): Upgrade dependencies
- perf(fetch): Send platform as request to API for a better match
@TrainDoctor
Copy link
Member

Latest build is up, apologies for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AAGaming00 AAGaming00 Awaiting requested review from AAGaming00

@beebls beebls Awaiting requested review from beebls

Assignees

@ynhhoJ ynhhoJ

Labels
plugin-addition
Projects
SDH Tracker
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ynhhoJ @AAGaming00 @TrainDoctor @beebls