Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception when creating connection. #461

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Handle exception when creating connection. #461

merged 1 commit into from
Oct 2, 2017

Conversation

yaakov-h
Copy link
Member

@yaakov-h yaakov-h commented Oct 1, 2017

Fixes #455.

@JustArchi Want to do a quick review, considering you raised the issue?

This doesn't prevent users from getting themselves into a toxic situation (e.g. setting ProtocolTypes to WebSocket-only on Windows 7) but does trigger a disconnected callback, same as when the connection fails for any other reason.

@yaakov-h yaakov-h added the bug label Oct 1, 2017
@yaakov-h yaakov-h added this to the 2.0.0 milestone Oct 1, 2017
Copy link
Contributor

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good PR if all we want to do is raising OnDisconnected(). Since the issue itself is quite rare, I think this will be do just fine if we don't want to be trying to outsmart websockets themselves.

@JustArchi
Copy link
Contributor

JustArchi commented Oct 1, 2017

What I like the most in this is the fact that eventually bot will succeed to connect using TCP-based server when he's using not-only-websocket protocols, as CM list should be smart enough to push faulted server on the bottom. This works much better than current situation of stalled connection where you don't know what happened without taking a closer look - I think it's a good solution.

@yaakov-h yaakov-h merged commit 093a135 into master Oct 2, 2017
@yaakov-h yaakov-h deleted the fix-ws-win7 branch October 2, 2017 00:19
@JustArchi JustArchi mentioned this pull request Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants