Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle regex pattern for Value type #118

Merged
merged 10 commits into from
Nov 5, 2024
Merged

feat: Handle regex pattern for Value type #118

merged 10 commits into from
Nov 5, 2024

Conversation

deepakraog
Copy link
Contributor

@deepakraog deepakraog commented Nov 4, 2024 •
edited
Loading

This is the continuation work(#111) for handling regex pattern in jsonata-rs framework

@deepakraog deepakraog requested a review from tommy November 4, 2024 10:06
@deepakraog deepakraog self-assigned this Nov 4, 2024
@deepakraog deepakraog requested a review from a team as a code owner November 4, 2024 10:06
@deepakraog deepakraog added the enhancement New feature or request label Nov 4, 2024
tommy
tommy reviewed Nov 4, 2024
View reviewed changes
src/parser/tokenizer.rs Outdated Show resolved Hide resolved
src/parser/expressions.rs Outdated Show resolved Hide resolved
tommy
tommy approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@tommy tommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small commit with the changes I described and am approving. Feel free to merge when you're online if it looks good to you.

@deepakraog deepakraog added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 8b75dea Nov 5, 2024
5 checks passed
@deepakraog deepakraog deleted the t/regex-value branch November 5, 2024 07:38
@stedi-release-plz stedi-release-plz bot mentioned this pull request Nov 5, 2024
Closed
This was referenced Nov 12, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommy tommy tommy approved these changes

Assignees

@deepakraog deepakraog

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepakraog @tommy