Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Metrics and Tracing integrations #1279

Closed
TimHess opened this issue Apr 16, 2024 · 1 comment · Fixed by #1416
Closed

Revisit Metrics and Tracing integrations #1279

TimHess opened this issue Apr 16, 2024 · 1 comment · Fixed by #1416
Assignees
Labels
ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Milestone

Comments

@TimHess
Copy link
Member

TimHess commented Apr 16, 2024

Follow ups from #1278:

  • Is there significant value in the Steeltoe Tracing package? Compare with what Aspire does with regard to OpenTelemetry, maybe Steeltoe should exit this space or provide a slimmer way of helping users set up tracing
  • Export to Jaeger has been deprecated in favor of OTLP, we should remove Jaeger references
  • Wavefront integration does not behave like the other exporters (eg: private reference), it should align better
    • The Wavefront exporter should be tested against Wavefront again. I noticed the tracing sample will fail repeatedly sending metrics with the non-key that's configured, should we do more than check for the presence of a Uri when turning that on?

Work on adding Zipkin support for OTLP has begun here, but does not yet look ready for the Zipkin exporting to go away

Additionally, with regard to metrics, specifically Prometheus:

  • Does the actuator actually behave like an actuator? It looks like we're just configuring OpenTelemetry, I'm not sure it's actually integrated
  • Does everything with the exporter actually work? While updating management samples, Prometheus scraping did not work. Encountered error: invalid metric type "CLR memory usage gauge"
@TimHess TimHess added this to the 4.0.0-m2 milestone Apr 16, 2024
@TimHess TimHess added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Apr 16, 2024
@TimHess
Copy link
Member Author

TimHess commented Nov 6, 2024

I don't think we need to review what Aspire does in this space anymore, and the Wavefront functionality should be removed.

With current versions of relevant libraries, distributed tracing easily works between .NET and Spring apps.

Please let us know if you aren't happy with any of the above.

@TimHess TimHess modified the milestones: 4.0.0-m2, 4.0.0-m1 Nov 14, 2024
@TimHess TimHess changed the title Revisit Tracing integrations Revisit Metrics and Tracing integrations Nov 14, 2024
@TimHess TimHess self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant