Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenTelemetry packages #1278

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Update OpenTelemetry packages #1278

merged 2 commits into from
Apr 17, 2024

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Apr 16, 2024

Description

Updates Steeltoe to depend on stable OpenTelemetry packages, where available. Fixes broken build.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

- EnableGrpcAspNetCoreSupport was replaced by environment variable OTEL_DOTNET_EXPERIMENTAL_ASPNETCORE_ENABLE_GRPC_INSTRUMENTATION, see https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/test/OpenTelemetry.Instrumentation.Grpc.Tests/GrpcTests.server.cs
- Replace usage of IDeferredTracerProviderBuilder, see open-telemetry/opentelemetry-dotnet#4228
@bart-vmware
Copy link
Member Author

/azp run Steeltoe.All

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

sonarcloud bot commented Apr 16, 2024

@bart-vmware bart-vmware marked this pull request as ready for review April 16, 2024 13:30
@bart-vmware bart-vmware requested a review from TimHess April 16, 2024 13:30
@TimHess TimHess added Type/enhancement New feature or request ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Apr 16, 2024
TimHess
TimHess previously approved these changes Apr 16, 2024
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extremely minor suggestion, otherwise LGTM for current scope.

Co-authored-by: Tim Hess <tim.hess@broadcom.com>
@bart-vmware bart-vmware requested a review from TimHess April 17, 2024 11:35
@bart-vmware bart-vmware merged commit abc2e71 into main Apr 17, 2024
18 checks passed
@bart-vmware bart-vmware deleted the update-otel-packages branch April 17, 2024 12:01
@TimHess TimHess added this to the 4.0.0-m1 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants