Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLR Metrics to use EventCounters #256

Closed
hananiel opened this issue Feb 28, 2020 · 0 comments · Fixed by #305
Closed

Update CLR Metrics to use EventCounters #256

hananiel opened this issue Feb 28, 2020 · 0 comments · Fixed by #305
Assignees
@hananiel
Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request
Milestone
3.0.0-M3

Comments

@hananiel
Copy link
Contributor

Currently we use an "IPolledDiagnosticSource" which is a steeltoe abstraction that polls CLR metrics.
EventCounters give a new way to get these metrics in process (and also expose out of proc via EventPipe). We need to update the CLR Metrics Observer to use EventCounter. Other observers such aspnetcore still publish via DiagnosticSource/Listener and that code can remain the same.
https://github.com/dotnet/diagnostics/blob/eb13265352569304912eedaa66894eb760d6c158/documentation/design-docs/eventcounters.md
@hananiel hananiel added the Type/enhancement New feature or request label Feb 28, 2020
@hananiel hananiel self-assigned this Feb 28, 2020
@jkonicki jkonicki added ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Component/Management Issues related to Steeltoe Management (actuators) labels Mar 2, 2020
@jkonicki jkonicki added this to the 3.0.0-M3 milestone Apr 2, 2020
@hananiel hananiel mentioned this issue Apr 25, 2020
Merged
@jkonicki jkonicki mentioned this issue Jul 13, 2020
Closed
@jkonicki jkonicki mentioned this issue Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hananiel hananiel

Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request
Projects
None yet
Milestone
3.0.0-M3
Development

Successfully merging a pull request may close this issue.

Add CLR Eventsource and EventCounter Metrics SteeltoeOSS/Steeltoe
2 participants
@jkonicki @hananiel