Add CLR Eventsource and EventCounter Metrics #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
+ Coverage 53.05% 53.21% +0.16%
==========================================
Files 1098 1102 +4
Lines 36748 37062 +314
Branches 7236 7299 +63
==========================================
+ Hits 19496 19723 +227
- Misses 15480 15548 +68
- Partials 1772 1791 +19
Continue to review full report at Codecov.
|
dtillman
previously approved these changes
Apr 29, 2020
TimHess
reviewed
Apr 29, 2020
| [Theory] | ||
| [MemberData(nameof(EndpointMiddleware_ContentNegotiation_TestCases))] | ||
| public async void EndpointMiddleware_ContentNegotiation(EndpointNames epName, string epPath, MediaTypeVersion version, string[] accepts, string contentType, string name) | ||
| public async void EndpointMiddleware_ContentNegotiation(EndpointNames epName, string epPath, string[] accepts, string contentType, string name) |
There was a problem hiding this comment.
@hananiel This might be one to add an exception for (in tests)
hananiel
force-pushed
the
EventCounterCLR
branch
from
6946414 to
1c6defd
Compare
TimHess
reviewed
Apr 29, 2020
src/Management/src/EndpointBase/Metrics/Observer/EventSourceListener.cs
Outdated
Show resolved
Hide resolved
hananiel
force-pushed
the
EventCounterCLR
branch
from
c3a2dda to
7991fa8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
TimHess
approved these changes
Apr 29, 2020
jkonicki
added
ReleaseLine/3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics end-end with metrics and prometheus actuators
Make updates to MetricsEndpoint to serialize metrics correcty
Resolves #256 and Partially #299