Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make emailService.js reusable and make different email templates #55

Closed
StefanPenchev05 opened this issue Mar 13, 2024 · 0 comments · Fixed by #58
Closed

Make emailService.js reusable and make different email templates #55

StefanPenchev05 opened this issue Mar 13, 2024 · 0 comments · Fixed by #58
Assignees
Labels
development Still in the development phase enhancement New feature or request frontend Changes that affect the frontend

Comments

@StefanPenchev05
Copy link
Owner

The current implementation of the emailService.js file is specifically tailored for sending verification emails during user registration. This limits the reusability of the code for other types of emails that the application might need to send, such as password reset emails, welcome emails, or promotional emails.

The goal of this issue is to refactor the sendVerifyMail to sendMail function in emailService.js to make it more generic and reusable. This involves abstracting the email sending logic and allowing different email templates to be used based on the type of email being sent.

Additionally, we should create a set of email templates for different scenarios. These templates should be customizable with variables for things like the recipient's name, verification links, etc.

By making these changes, we can ensure that our email service is flexible and can handle a variety of email sending tasks.

@StefanPenchev05 StefanPenchev05 added enhancement New feature or request development Still in the development phase frontend Changes that affect the frontend labels Mar 13, 2024
@StefanPenchev05 StefanPenchev05 self-assigned this Mar 13, 2024
StefanPenchev05 added a commit that referenced this issue Mar 13, 2024
StefanPenchev05 added a commit that referenced this issue Mar 13, 2024
@StefanPenchev05 StefanPenchev05 linked a pull request Mar 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Still in the development phase enhancement New feature or request frontend Changes that affect the frontend
Projects
Development

Successfully merging a pull request may close this issue.

1 participant