-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow style not displaying #15
Comments
Interesting, can you upload screenshots to show the difference, or submit a PR with your fix? |
I also noticed this, I added a package patch to add the shadow but it wouldn't open on android after my attempt, I'll try to look into this some more. If I find a good solution I'll open a PR |
@braxtonchristensen @SilentChris Did you guys ever get this to work consistently? I would be happy to merge in some code and test if you have working code in a fork or locally. |
I don't think I ever came up with a great solution here. Since we don't use popovers in a lot of places, I just have it switching styles based on |
The issue is there because of This, however, is not a solution I would want for the library. There is an open issue with React Native facebook/react-native#449 but was closed and moved to ProductPains. Please upvote the issue here https://react-native.canny.io/feature-requests/p/shadow-does-not-appear-if-overflow-hidden-is-set-on-ios. |
That's good to know, I do allow a |
For now, I'll probably make it so that |
I made this change, will be released with 4.2.0 |
Version 5.0.0 released, which includes many shadow-related fixes and improvements (see https://github.com/SteffeyDev/react-native-popover-view#upgrading) |
Running on React Native 0.55.4
I noticed that the default styles for the popover include a box shadow around the view. Unfortunately, this doesn't seem to be displaying.
It seems that the issue might be a conflict with
Animated.View
and theboxShadow
styles. If I manually hack it so that the styles get applied to a regularView
child below theAnimated.View
, the shadow displays as expected.The text was updated successfully, but these errors were encountered: