Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality improvements #178

Merged
merged 3 commits into from
May 20, 2022
Merged

Code quality improvements #178

merged 3 commits into from
May 20, 2022

Conversation

oleg20111511
Copy link
Contributor

  1. Removed raw calls to Telegram Bot API and replaced them with python-telegram-bot methods. This way if someone wants to use self-hosted API server it can be done by changing it in just one place on Bot instance initialization.

  2. Fixed an issue when, while editing a product without a price, part of the string would not be localized

@Steffo99
Copy link
Owner

Thanks for the PR!

I vaguely remember a reason for not using those methods there, I'll have to perform some tests when I'm back home!

@Steffo99 Steffo99 added feature A request for a new feature. chore An improvement in code quality that doesn't involve development of a new feature. labels May 16, 2022
@Steffo99 Steffo99 self-assigned this May 16, 2022
@Steffo99 Steffo99 self-requested a review May 16, 2022 09:08
database.py Show resolved Hide resolved
@Steffo99 Steffo99 self-requested a review May 20, 2022 00:51
@Steffo99 Steffo99 merged commit 55e14b1 into Steffo99:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore An improvement in code quality that doesn't involve development of a new feature. feature A request for a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants