Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unchecking "Only orbit for selected object" still hides other planets' orbits #1842

Closed
Atque opened this issue Aug 20, 2021 · 3 comments · Fixed by #3348
Closed

Unchecking "Only orbit for selected object" still hides other planets' orbits #1842

Atque opened this issue Aug 20, 2021 · 3 comments · Fixed by #3348
Assignees
@gzotti
Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash state: confirmed A developer can reproduce the issue
Milestone
23.3

Comments

@Atque
Copy link
Contributor

Atque commented Aug 20, 2021

This seems like a bug.

Displaying orbits, and unchecking "Only orbit for selected object" still hides other planets' orbits if one planet is selected (for example, selecting Jupiter will hide every planet's orbit except Jupiter's).

Tested with the latest public beta on a Windows 10 machine, but IIRC this is an old bug.
@gzotti gzotti added bug Something likely wrong in the code state: confirmed A developer can reproduce the issue importance: medium A bit annoying, minor miscalculation, but no crash labels Aug 20, 2021
@github-actions
Copy link

Hello @Atque! OK, developers can reproduce the issue. Thanks for the report!

A-j-K added a commit to A-j-K/stellarium that referenced this issue Nov 17, 2021
@A-j-K
Fix issue Stellarium#1842
5c5b8f5
A-j-K added a commit to A-j-K/stellarium that referenced this issue Nov 17, 2021
@A-j-K
Fix issue Stellarium#1842
bc5575e
@A-j-K A-j-K mentioned this issue Nov 17, 2021
Closed
12 tasks
gzotti added a commit that referenced this issue Aug 2, 2023
@gzotti
Fix the botched logic of storing details for the orbit drawing (Fix #…
116f8d1 
…1842)

- This has been attempted also in #2043, but I think this is more comprehensive.
- In addition, immediate-mode storage has been added to the Orbit details.
- In addition, a bug about storing line width has been fixed.
@gzotti gzotti mentioned this issue Aug 2, 2023
Merged
13 tasks
gzotti added a commit that referenced this issue Aug 2, 2023
@gzotti
Fix the botched logic of storing details for the orbit drawing (Fix #…
c6c3411 
…1842)

- This has been attempted also in #2043, but I think this is more comprehensive.
- In addition, immediate-mode storage has been added to the Orbit details.
- In addition, a bug about storing line width has been fixed.
gzotti added a commit that referenced this issue Aug 6, 2023
@gzotti
Fix: orbit details (#3348)
dd6ca5b 
* Add another option and StelApp method to allow storing config items immediately
- the intention is to start using this for storing detail settings without having to do the global store.

* Fix the botched logic of storing details for the orbit drawing (Fix #1842)
- This has been attempted also in #2043, but I think this is more comprehensive.
- In addition, immediate-mode storage has been added to the Orbit details.
- In addition, a bug about storing line width has been fixed.

* Add option to add or exclude moon orbits for planets/selected objects

* SUG: Add new details
@gzotti gzotti self-assigned this Aug 6, 2023
@gzotti gzotti added this to the 23.3 milestone Aug 6, 2023
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Sep 2, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello @Atque!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 26, 2023
@github-actions
Copy link

Hello @Atque!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzotti gzotti

Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash state: confirmed A developer can reproduce the issue
Milestone
23.3
Development

Successfully merging a pull request may close this issue.

Fix: orbit details Stellarium/stellarium
Fix issue #1842 A-j-K/stellarium
3 participants
@alex-w @gzotti @Atque