Stellarium doesn't run with commit f74171a... with certain screen resolution settings and multi monitor setup #3102
Comments
cat ~/.stellarium/config.ini
|
|
With commit f74171a: I have changed the values in the now it starts and runs in full screen. Interestingly I had to double the |
mesonium
changed the title
|
At what values does it start to fail? :) Also, please post the log with the following patch (and the original failing config values): test.patch.gz. |
For Will test the patch next. By the way, is this line correct? You divide by |
With |
|
What if you set |
This setting makes no difference. It turned out to be multi monitor issue:
The screens are logically arranged next to each other
|
mesonium
changed the title
|
Please post failure log with this patch: test1.patch.gz. |
Against which commit in which branch? I cannot apply this patch to the current head in master (c6e3f1a). |
|
d07ab02, as you specified in the OP. |
I am confused: https://github.com/Stellarium/stellarium/blob/master/src/StelMainView.cpp#L918 this, which is the same in my local git master checkout, doesn't look like the line you'd like me to replace in your patch. |
|
The patch doesn't mention |
Nevermind, somehow the extracting did not work as expected and I had an older patch with basically the same name lying around, which totally confused the hell out of me. Here's the debug output with test1.patch and the problematic settings (1024x768, screen 0 (right screen)): If screen 0 is on the left: |
Well, Qt's GUI scaling is utterly broken (as I noticed many times with other problems). So you have a 1920px-wide screen on the left, with 100% scale factor. And a 3840px-wide screen on the right, with a scale factor of 200%. And Qt reports the geometry as a mixture of physical pixel offset (or virtual with respect to the screen on the left?!) and virtual pixel size. This really sucks. I wonder if they consider it a bug or a feature. Moreover, I don't even know what happens if the screen on the left has scale≠100%: does the offset change? Or can we rely that in Qt6 (and Qt5?) the offset always represents physical pixels? |
With 150% scaling on the left, when Stellarium is supposed to start on the right (with 200%): with 200% for both: with 250% | 200%: |
|
OK, please check if the following patch fixes the problem: test2.patch.gz. If yes, then please also check whether a position of non-fullscreened window is restored at the same place as when you pressed "Save settings" after moving it. |
\o/ it does fix the problem.
It correctly saves the window geometry (width / height) but it always restores the window at the screen, where it was opened and it always places it at the center. For testing I had made the Stellarium windowd (F11), resized it and moved it to some position, hit F2 and saved view and settings. |
|
Hmm, does Wayland actually let apps control positions of their windows? |
Right, the compositor / window manager is actually responsible for the toplevel window position on Wayland. |
|
The issue is almost solved: After saving the settings, when Stellarium is in fullscreen: This is the right geometry for the windowed Stellarium, however when starting Stellarium now, it goes to fullscreen, but only occupies the upper left part of the screen with the height/width given in the config file. Making it fullscreen, hitting F2 and saving the settings doesn't help. |
|
How did this behave before the faulty commit? |
Just checked again, and the behavior was the same, so no regression. Thanks! :) |
alex-w
added
the
state: published
|
Hello @mesonium! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @mesonium! Please check the latest stable version of Stellarium: |
Issue
Stellarium doesn't start for me, i.e. it shows the splash screen and the log output beneath, but then nothing happens. The process keeps idling in the background.
I used
git bisectto idendtify commit f74171a as the faulty one.Reverting this commit makes Stellarium work again.
Steps to reproduce
cmake -DENABLE_SHOWMYSKY=OFF ../.. && make~/path/to/src/stellarium --verboseSystem
Operating System: openSUSE Tumbleweed 20230312
KDE Plasma Version: 5.27.2
Qt Version: 6.4.2-2.2
Kernel Version: 6.2.2-1-default (64-bit)
Graphics Platform: Wayland
Graphics Processor: AMD Radeon RX 580 Series
Logfile
(gdb) thread apply all bt
The text was updated successfully, but these errors were encountered: