-
-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt6 and fullscreen=true: Stellarium's window opens with width / height as defined in the config.ini for the window mode #2755
Comments
Thanks for adding your first issue to Stellarium. If you have questions, please do not hesitate to contact us. |
Did you tried enable full screen mode within Stellarium and saving settings? |
I just tried
I am not quiet sure what you mean. |
|
Here's another log with WAYLAND_DEBUG=1 stellarium --verbose --fullscreen
|
I followed the steps again:
Now I am in the same situation as described in the OT. |
From the log:
This is exactly the window size (1280x960) with which stellarium opens for me, whereby 3840/3=1280 and 3840/4=960 if this makes any sense. |
This may be due to problems with Wayland support in Qt5. It might help if you try with Qt 6.3 or higher (needs rebuild of Stellarium). |
Isn't it already built against Qt6 as of
since the version number is 1.22.3 according to |
As workaround: Toggling between "Window mode" an "Fullscreen" via F11 works, after Stellarium opens as a non-window in the upper-left corner. |
Built it against Qt 6.4.0
and the issue remains unfortunately. |
Does the patch below help? diff --git a/src/StelMainView.cpp b/src/StelMainView.cpp
index 7cef2a507a..d9bfe6f36d 100644
--- a/src/StelMainView.cpp
+++ b/src/StelMainView.cpp
@@ -918,7 +918,7 @@ void StelMainView::init()
// the normal window. Therefore we crop the normal window to the
// screen area to ensure that the majority is not on another screen.
setGeometry(geometry() & screenGeom);
- setFullScreen(true);
+ QTimer::singleShot(0, [this]{setFullScreen(true);});
}
else
{ |
Unfortunately not. |
Hmm, and what if we change the timeout to e.g. 3 seconds, as below? diff --git a/src/StelMainView.cpp b/src/StelMainView.cpp
index 7cef2a507a..d9bfe6f36d 100644
--- a/src/StelMainView.cpp
+++ b/src/StelMainView.cpp
@@ -918,7 +918,7 @@ void StelMainView::init()
// the normal window. Therefore we crop the normal window to the
// screen area to ensure that the majority is not on another screen.
setGeometry(geometry() & screenGeom);
- setFullScreen(true);
+ QTimer::singleShot(3000, [this]{setFullScreen(true);});
}
else
{ |
That works: Stellarium first opens in a window as shown in #2755 (comment) and then after 3 seconds it goes to fullscreen as expected. The delay could be decreased down to a minimum of |
@mesonium please try build the master |
I have tested the latest master build but the issue is still there. Here's another log: WAYLAND_DEBUG=1 ./src/stellarium --verbose
However, at least I can confirm now that version 1.0 (stable) and 1.0 (git master) work fine under X11. So it's purely a Wayland issue. |
Please check the fresh version (development snapshot) of Stellarium: |
I tested the latest master build (with a In the meantime, I have checked Stellarium on Fedora 36 with Plasma 5.25/5.26 Wayland on my Intel machine: There it also opens in the upper left corner first too , but only for a very short split-second and then correctly resizes by itself to fullscreen. |
Please check the fresh version (development snapshot) of Stellarium: |
On my 200% scaled screen with Plasma 5.27.2 Wayland, this now works fine: Thanks! :) Unfortunately I cannot test my local build against Qt6 as it won't start:
It stops at this point when the splash screen vanishes. But this may be another issue. |
Do you launch the test build from inside the source directory? |
Please see issue #3102. When reverting the faulty commit, I experience the same issue with local build against Qt6 again. The latest official Appimage (using Qt5) works fine though. |
As commented on #3102 With commit f74171a on git master: I have changed the values in the
now it starts and runs in full screen. Interestingly I had to double the The actual resolution of the screen is 3840x2160 and uses a scaling of 200%. |
With this patch posted in #3102 (comment) the local build of Stellarium runs fine again. However, the issue of this thread still persists with my local build against Qt6. The offical appimage build against Qt5 has and works flawlessly. Shall I reopen? Can anyone reproduce the issue when building against Qt6? |
Hello @mesonium! Please check the fresh version (development snapshot) of Stellarium: |
When building with |
|
Hello @mesonium! Please check the latest stable version of Stellarium: |
First of all, congratulations to v1.0!
I first had reported it upstream to the KDE Plasma developers, but I was asked to report it downstream instead.
Expected Behaviour
Stellarium opens in fullscreen.
Actual Behaviour
Stellarium always opens in the upper left corner like shown in the screenshot:
Steps to reproduce
Stellarium is displayed as in the screenshot above.
Stellarium's window now becomes fullscreen as expected.
Stellarium stays fullscreen.
System
Stellarium version: 1.0
Operating system: openSUSE TW with KDE Plasma 5.26.0 Wayland
Graphics Card:
Screen type (if applicable): 3840x2160, HighDPI, 200% scaling
Operating System: openSUSE Tumbleweed 20221016
KDE Plasma Version: 5.26.0
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6 + 6.4.0
Kernel Version: 6.0.1-1-default (64-bit)
Logfile
stellarium --verbose
The text was updated successfully, but these errors were encountered: