Added custom filter for satellites #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JAY-Githb please see this PR |
|
This PR also partially fixes the issue #1527 ("Known standard magnitude" flag) - original requirement doesn't make sense IMHO. |
|
OK, the PR is ready to review (need SUG update) |
|
OK, the SUG is done |
|
Just checking... |
gzotti
reviewed
May 23, 2022
gzotti
approved these changes
May 23, 2022
|
Hi.
I can't find that update.
Can you furnish a direct link to the Windows version?
Thank you.
Jay Respler
Advanced Business Machines Co.
609-662-7438
***@***.***
Monroe Township, New Jersey
… From: "Alexander V. Wolf" ***@***.***>
To: "Stellarium/stellarium" ***@***.***>
Cc: "JAY RESPLER" ***@***.***>, "Mention"
***@***.***>
Sent: Monday, May 23, 2022 4:32:36 AM
Subject: Re: [Stellarium/stellarium] Added custom filter for satellites (PR
#2457)
[ https://github.com/JAY-Githb | @JAY-Githb ] please see this PR
—
Reply to this email directly, [
#2457 (comment) |
view it on GitHub ] , or [
https://github.com/notifications/unsubscribe-auth/AODP7UN5HWWPUVGCZMOIW6TVLM7CJANCNFSM5WU7TN7A
| unsubscribe ] .
You are receiving this because you were mentioned. Message ID:
<Stellarium/stellarium/pull/2457/c1134356577 @ github . com>
|
Binary packages are not prepared yet |
|
I saw the proposed Satellite Filter.
It looks very nice.
Jay Respler
Advanced Business Machines Co.
609-662-7438
***@***.***
Monroe Township, New Jersey
… From: "Alexander V. Wolf" ***@***.***>
To: "Stellarium/stellarium" ***@***.***>
Cc: "JAY RESPLER" ***@***.***>, "Mention"
***@***.***>
Sent: Monday, May 23, 2022 1:08:10 PM
Subject: Re: [Stellarium/stellarium] Added custom filter for satellites (PR
#2457)
> Hi. I can't find that update. Can you furnish a direct link to the Windows
> version?
Binary packages are not prepared yet
—
Reply to this email directly, [
#2457 (comment) |
view it on GitHub ] , or [
https://github.com/notifications/unsubscribe-auth/AODP7UIFX6TTXODOFJQL7UDVLO3PVANCNFSM5WU7TN7A
| unsubscribe ] .
You are receiving this because you were mentioned. Message ID:
<Stellarium/stellarium/pull/2457/c1134929769 @ github . com>
|
|
Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium: |
gzotti
added a commit
that referenced
this pull request
Jun 8, 2022
Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti
added a commit
that referenced
this pull request
Jun 8, 2022
Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
|
Hello @alex-w! Please check the latest stable version of Stellarium: |
|
As I noted elsewhere, GREAT JOB! Jay |
gzotti
added a commit
that referenced
this pull request
Jul 18, 2022
Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti
added a commit
that referenced
this pull request
Jul 18, 2022
Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti
added a commit
that referenced
this pull request
Jul 22, 2022
Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti
added a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti
added a commit
that referenced
this pull request
Jul 30, 2022
Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request I added ability use customisation filter the list of satellites by few criterias, e.g. apogee, perigee, inclination, etc. The discussion about requirements for this filter was via email. The UI and behaviour is similar to Satellites filter in HeavenSat program.
Fixes #2060 (issue)
Screenshots:
Satellites filter in HeavenSat:
Type of change
Checklist: