Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI for manual addition of comm frequencies for satellites #2476

Merged
merged 13 commits into from
Jun 3, 2022
Merged

GUI for manual addition of comm frequencies for satellites #2476

merged 13 commits into from
Jun 3, 2022

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Jun 1, 2022 •
edited
Loading

This feature was added into TODO list (item: GUI for manual addition of comm frequences) for Satellites plugin at least 9 years ago, but it was probably earlier. I've added the GUI to adding and removing the communication data for individual satellites only - the tool doesn't support groups of satellites (this is intended behaviour!).

Screenshots:

satellites_plugin_satellites
satellites_plugin_comms

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w added this to the 0.22.2 milestone Jun 1, 2022
@github-actions github-actions bot requested a review from gzotti June 1, 2022 04:16
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited by alex-w
Loading

Great PR! Please pay attention to the following items before merging:

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files

@alex-w
Copy link
Member Author

alex-w commented Jun 2, 2022 •
edited
Loading

OK, it's ready for merge (after #2479)

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the has conflicts The pull request has conflicts label Jun 2, 2022
@github-actions github-actions bot removed the has conflicts The pull request has conflicts label Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Conflicts have been resolved. A maintainer will review the pull request shortly.

@alex-w
Copy link
Member Author

alex-w commented Jun 2, 2022

@gzotti please review “wording” for new part of GUI also, I guess it can be improved and clearer

@alex-w
Copy link
Member Author

alex-w commented Jun 2, 2022

Done.

What about "Data description" as suggestion for field 'description' and "Communications" as title?

@gzotti
Copy link
Member

gzotti commented Jun 2, 2022

Done.

What about "Data description" as suggestion for field 'description' and "Communications" as title?

Probably:

Communications --> Frequencies

Data Description: I don't know, it may be ok, or be something like "channel name" or "link name"? Maybe Jay can propose a better name. (What was his user name?)

@alex-w
Copy link
Member Author

alex-w commented Jun 2, 2022

Communications --> Frequencies

Good suggestion.

Data Description: I don't know, it may be ok, or be something like "channel name" or "link name"? Maybe Jay can propose a better name. (What was his user name?)

Channel name looks good.

@JAY-Githb could you review it too?

@alex-w
Copy link
Member Author

alex-w commented Jun 3, 2022

@gzotti what about changes?

@gzotti
Copy link
Member

gzotti commented Jun 3, 2022

I thought we wait for a suggestion by @JAY-Githb. Else OK for me.

@alex-w
Copy link
Member Author

alex-w commented Jun 3, 2022

👍

Thanks!

@alex-w alex-w merged commit d6a0a9d into master Jun 3, 2022
@alex-w alex-w deleted the satellites/radiofrequency-editor branch June 3, 2022 13:14
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@JAY-Githb
Copy link
Contributor

JAY-Githb commented Jun 8, 2022 via email

gzotti added a commit that referenced this pull request Jun 8, 2022
@alex-w @gzotti
Added GUI for manual addition of comm frequencies for satellites (#2476)
4dba341 
This feature was added into TODO list (item: GUI for manual addition of comm frequences) for Satellites plugin at least 9 years ago, but it was probably earlier. I've added the GUI to adding and removing the communication data for individual satellites only - the tool doesn't support groups of satellites (this is intended behaviour!).

Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti added a commit that referenced this pull request Jun 8, 2022
@alex-w @gzotti
Added GUI for manual addition of comm frequencies for satellites (#2476)
26d71b4 
This feature was added into TODO list (item: GUI for manual addition of comm frequences) for Satellites plugin at least 9 years ago, but it was probably earlier. I've added the GUI to adding and removing the communication data for individual satellites only - the tool doesn't support groups of satellites (this is intended behaviour!).

Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Hello @alex-w! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

gzotti added a commit that referenced this pull request Jul 18, 2022
@alex-w @gzotti
Added GUI for manual addition of comm frequencies for satellites (#2476)
ba04c12 
This feature was added into TODO list (item: GUI for manual addition of comm frequences) for Satellites plugin at least 9 years ago, but it was probably earlier. I've added the GUI to adding and removing the communication data for individual satellites only - the tool doesn't support groups of satellites (this is intended behaviour!).

Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti added a commit that referenced this pull request Jul 18, 2022
@alex-w @gzotti
Added GUI for manual addition of comm frequencies for satellites (#2476)
3cdcb17 
This feature was added into TODO list (item: GUI for manual addition of comm frequences) for Satellites plugin at least 9 years ago, but it was probably earlier. I've added the GUI to adding and removing the communication data for individual satellites only - the tool doesn't support groups of satellites (this is intended behaviour!).

Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti added a commit that referenced this pull request Jul 22, 2022
@alex-w @gzotti
Added GUI for manual addition of comm frequencies for satellites (#2476)
3d54bc4 
This feature was added into TODO list (item: GUI for manual addition of comm frequences) for Satellites plugin at least 9 years ago, but it was probably earlier. I've added the GUI to adding and removing the communication data for individual satellites only - the tool doesn't support groups of satellites (this is intended behaviour!).

Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti added a commit that referenced this pull request Jul 29, 2022
@alex-w @gzotti
Added GUI for manual addition of comm frequencies for satellites (#2476)
fac396d 
This feature was added into TODO list (item: GUI for manual addition of comm frequences) for Satellites plugin at least 9 years ago, but it was probably earlier. I've added the GUI to adding and removing the communication data for individual satellites only - the tool doesn't support groups of satellites (this is intended behaviour!).

Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
gzotti added a commit that referenced this pull request Jul 30, 2022
@alex-w @gzotti
Added GUI for manual addition of comm frequencies for satellites (#2476)
33fcf73 
This feature was added into TODO list (item: GUI for manual addition of comm frequences) for Satellites plugin at least 9 years ago, but it was probably earlier. I've added the GUI to adding and removing the communication data for individual satellites only - the tool doesn't support groups of satellites (this is intended behaviour!).

Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzotti gzotti gzotti left review comments

Assignees

@alex-w alex-w

Labels
todo 🗒️
Milestone
0.22.2
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-w @gzotti @JAY-Githb