Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace world map with a higher-resolution version #2742

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

10110111
Copy link
Contributor

@10110111 10110111 commented Oct 9, 2022

Description

The current world map in the Location dialog has very poor resolution by today's standards: 500×250 pixels for the whole globe. This makes it useless to resize the Location dialog to see the map closer.

This patch replaces the old map with a 5400×2700 version, taken from NASA Blue Marble Next Generation dataset for July 2004. As I understand, NASA imagery is in public domain, so copyright issues shouldn't arise.

The water here is marked with a darker color, but I think it's not critical.

Screenshots

Old map:

old

New map:

new

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update section Graphics in CREDITS.md file

The map was taken from NASA Blue Marble Next Generation dataset for July 2004.
@alex-w alex-w added the enhancement Improve existing functionality label Oct 10, 2022
@alex-w alex-w merged commit a17a51a into Stellarium:master Oct 10, 2022
@alex-w alex-w added this to the 1.1 milestone Oct 10, 2022
@gzotti
Copy link
Member

gzotti commented Oct 10, 2022

While I agree on having a higher-res texture in principle, this will probably not work on systems with limited texture size. I have not tried yet, but OpenGL ES systems, esp. SBC like RPi3, may be limited to 2048x2048px (not sure about ANGLE). See my RPi3 remarks in #2729 : Probably even the larger button icons cause an issue by filling texture memory, so there is no more left for sky textures. I cannot say what the solution is, having some tool to reduce all textures after installation? Or adding code into the texture loader to reduce texture sizes on such systems?

@10110111
Copy link
Contributor Author

this will probably not work on systems with limited texture size

miscWorldMap.* is only used via QPixmap::scaled and QPainter, so it shouldn't lead to any problems with texture size limit. Until we really find problems, it's just speculation.

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 12, 2022
@github-actions
Copy link

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@10110111 10110111 deleted the high-res-map branch October 20, 2022 15:50
@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Oct 31, 2022
@github-actions
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Development

Successfully merging this pull request may close these issues.

3 participants