Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the src/ subdirectory #2857

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Nov 19, 2022

Description

Fixes all comment or documentation typos in the src/ subdir
Found via codespell -q 3 -S *.po,*.pot,*.utf8,ChangeLog,./src/external,./plugins/RemoteControl/webroot/js -L anonymus,dout,inout,lod,ned,ser,te,tht,ue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housecleaning

How Has This Been Tested?

n/a

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Found via `codespell -q 3 -S *.po,*.pot,*.utf8,ChangeLog,./src/external,./plugins/RemoteControl/webroot/js -L anonymus,dout,inout,lod,ned,ser,te,tht,ue`
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your first pull request to Stellarium. If you have questions, please do not hesitate to contact us.

Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@gzotti gzotti merged commit 21cfcec into Stellarium:master Nov 19, 2022
@luzpaz luzpaz deleted the typos/src branch November 19, 2022 22:33
@alex-w alex-w added this to the 1.2 milestone Nov 20, 2022
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 20, 2022
@github-actions
Copy link

Hello @luzpaz!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 25, 2022
@github-actions
Copy link

Hello @luzpaz!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 25, 2022

MY machine crashed after a manjaro update. I can't check ATM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants