Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change encoding format in Korean.isl #2992

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Change encoding format in Korean.isl #2992

merged 3 commits into from
Jan 14, 2023

Conversation

ysjbserver
Copy link
Contributor

@ysjbserver ysjbserver commented Jan 14, 2023

Description

About the text error I reported, I think it's just the encoding format problem of the installer file. I changed nothing except encoding format (from EUC-KR to UTF-8).

Fixes #2988

Screenshots (if appropriate):

Type of change

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

About the text error I reported, I think it's just the encoding format problem of the installer file. I changed nothing except encoding format (from EUC-KR to UTF-8).
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, encoding is a probable cause. Thank you!

Copy link
Contributor

@10110111 10110111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense.

@alex-w
Copy link
Member

alex-w commented Jan 14, 2023

In the file you can see string LanguageCodePage=949 - it should be changed too after changing encoding IMHO.

@alex-w
Copy link
Member

alex-w commented Jan 14, 2023

Stop! Did you check Qt5-based Stellarium?

@ysjbserver
Copy link
Contributor Author

ysjbserver commented Jan 14, 2023

Since the language code for EUC-KR is 51949, not 949, I don't think that should matter. I guess it kinda needs to be changed to 65001 (UTF-8), but I'm unsure if it's necessary.
Edit: I checked again and encoding error was the other way around. Text itself was fine, but language code was wrong. Honestly I don't know why only two lines were affected, or why the file format was "EUC-KR", not "ks_c_5601-1987" (949) or UTF-8.

And sorry for my lack of programming knowledge, but I don't get what you mean check Qt5-based.

@alex-w
Copy link
Member

alex-w commented Jan 14, 2023

And sorry for my lack of programming knowledge, but I don't get what you mean check Qt5-based.

Please try download and install version 1.2-qt5 of Stellarium - we use ISS5 for Qt5-based planetarium and ISS6 for Qt6-based edition respectively.

Also changing encoding number, just to be safe
@ysjbserver
Copy link
Contributor Author

Please try download and install version 1.2-qt5 of Stellarium - we use ISS5 for Qt5-based planetarium and ISS6 for Qt6-based edition respectively.

Thank you! I just checked and the issue was the same. Exact same text at the exact same position. I checked Qt6 again, just to be sure, and it was the same.

@alex-w alex-w merged commit a72376f into Stellarium:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Character Error in Korean Installer
4 participants