Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic-icon in mime file #3011

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Use generic-icon in mime file #3011

merged 1 commit into from
Jan 22, 2023

Conversation

yselkowitz
Copy link
Contributor

Description

Since icons were standardized in shared-mime-info spec version 0.16, only generic-icon is recognized in the system database, where this file is installed by distribution packages. This fixes the use of the mime-type icon on recent GNOME versions.

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

By modifying the mime file locally, downloading a script, and opening the containing directory in my file manager.

Test Configuration:

  • Operating system: Fedora 37
  • Graphics Card: N/A

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Since icons were standardized in shared-mime-info spec version 0.16, only generic-icon is recognized in the system database, where this file is installed by distribution packages.  This fixes the use of the mime-type icon on recent GNOME versions.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your first pull request to Stellarium. If you have questions, please do not hesitate to contact us.

@alex-w alex-w added this to the 23.1 milestone Jan 22, 2023
@alex-w alex-w added the infrastructure Infrastructure related issues label Jan 22, 2023
@alex-w alex-w merged commit 2a50f9a into Stellarium:master Jan 22, 2023
@yselkowitz yselkowitz deleted the patch-1 branch January 22, 2023 12:10
@github-actions
Copy link

Hello @yselkowitz!

The enhancement or feature has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@github-actions
Copy link

Hello @yselkowitz!

The fix has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed labels Mar 13, 2023
@github-actions
Copy link

Hello @yselkowitz!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 27, 2023
@github-actions
Copy link

Hello @yselkowitz!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issues
Development

Successfully merging this pull request may close these issues.

2 participants