Discovery Circumstances for Solar System Objects

[alex-w]

Description

This pull request added support the discovery circumstances for solar system objects (except comets, but the date of discovery included into designation of the comets).

Features:

• Added discovery circumstances for major planets and their moons into ssystem_major.ini file
• Added discovery circumstances for minor planets and comets into ssystem_minor.ini file
• Solar System Editor plugin adds discovery circumstances for numbered minor planets now

Extra features:

• Solar System Editor plugin adds IAU designations for periodical comets with old-style designations now
• Search Tool support search minor planets and comets by IAU designations also

Partially fixes #3224 (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• This change requires a documentation update

How Has This Been Tested?

• Run Stellarium
• Find Ceres and check the info
• Run Solar System Editor (SSE) plugin and update the data for Ceres
• Check Ceres info again
• Find Quaoar and check the info
• Run SSE plugin and update the data for Quaoar
• Check Quaoar info again
• Find 2P/Encke and check the info
• Run SSE plugin and update the data for comet Encke
• Check comet Encke info again
• Try find Quaoar and comet Encke by extra designations

Checklist:

• My code follows the code style of this project.
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (header file)
• I have updated the respective chapter in the Stellarium User Guide
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

• Are possibly unused includes removed?

Files matching guide/**:

• Did you remember to update screenshots to match new updates?
• Did you remember to grammar check in changed part of documentation?

Files matching skycultures/**:

• Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
• Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
• Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
• Did you remember to define classification parameter in sky cultures (see info.ini file)?
• Did you remember to define license parameter in sky cultures (see info.ini file)?
• Did you remember to define region parameter in sky culture (see info.ini file)?

This is an automatically generated QA checklist based on modified files.

[alex-w]

Done, please review.

[alex-w]

OK, it's ready to review

[alex-w]

OK, it's ready to review. Some data is missing, but I haven’t the full books at the moment.

[alex-w]

OK, the pull request ready to review.

P.S. The question to updating the default list of comets has been moved into separate issue - see #3261

[gzotti]

The data are enormous! I have not seen an issue so far, and cannot test for a week. Probably OK for beta testing.

[github-actions]

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

[github-actions]

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest