Ensure Unicode strings are converted when compiling with Unicode enabled #3301
Conversation
|
Wouldn't it be better to always use Unicode-enabled |
|
Also, |
I currently don't have a system that can build a Qt5 version so my intention was to make changes that didn't disturb the build flow. In other words, I did what one would do in just 10 minutes to make it work ;) Quite happy to rework it that way but I'm blind to other builds to test it all. |
As I said previously, this is what I did in "10 minutes" just to get it working. We can improve on it if you desire. |
You can use the AppVeyor build that's configured in
Yes, please do. I really dislike how complicated the code is becoming. Even before this change the code looked needlessly complicated. So please make it simple, there's not a single reason to use 8-bit legacy code pages with Qt where |
|
@10110111 ok, I will look into that this evening as I am at work at the moment. Thanks for the feedback. |
|
You can use the Qt MaintenanceTool in your Qt directory to add Qt5.15.2 (make sure to add QtScript and the other required additional libraries). Then in QtCreator, select the Kit for Qt5.15.2 and in the cmake configuration, make sure to set ENABLE_QT6 to false/0. You may need to set Qt5 libs instead of Qt6 into PATH as well. +1 for simpler code. Note that most of the telescope plugin code roots in Qt4 times. I did the Qt6 ifdefs and was happy I could compile it, but had no hardware to test. If there are functions that work on both, Qt5 and Qt6, it's preferrable. Methods introduced after Qt5.12 would still be problematic, though, as the Qt5 releases are AFAIK still made with 5.12. @alex-w is Qt5.9 still used somewhere, or could we raise at least to 5.12? |
No, we can update requirements up to Qt 5.12 |
|
Probably this PR fixed #3006 already |
Was tested for Qt5 and Qt6 using SkyWatcher SynScan Handcontroller and AZ-GTiX mount. |
This is the case. For Qt6 my SynScan Hand controller did not work but it did work for Qt5. It now works for both. |
|
@A-j-K thanks a lot for this. Are you interested in fixing more of these telescope issues (https://github.com/Stellarium/stellarium/projects/20#card-87377309)? And even complete the emergency stop #2754? |
@gzotti I noticed the Project Board for the Telescope Plugin was somewhat weighty with issues. I'll take a look and see if there's anywhere I can add value. |
|
It is possible that this fix has already solved a handful of them. OPs would need to test their gear now with a new build. It's a pity 23.2 just came out, so this will likely take months... |
|
@alex-w Given that #3305 just happened would it be worth considering a point release? This situation is only going to get worse until that next minor release happens. @gzotti I spent yesterday evening reading every issue in the Telescope Project board looking for places to add value. I found little to none based entirely on the situation you already know, having the hardware to test. However, I don't see a reason to stop looking. Next, I will review the code as I saw it mentioned that it's not async by design other than everything must be happening in the draw() loop (to some degree, I will know for sure when I actually look at the code itself). Once I have done a review and essentially reverse-engineered how it all works I will probably come forward with a proposal on the way forward. |
|
I also have just fixed another error around a message connection that was renamed in Qt5.15 and would never have worked on Qt6. Whatever reported issue this probably fixes I cannot say as we rarely receive useful logfiles (where this issue would have been visible). This is one of the big problems with the TC plugin: we would need ~30 devices to test on 3 OS and 2 CPU families, and 30 user-developers to debug and keep the program working with their own gear, not withdrawing to obsolete versions on the slightest hint of problem. So, any help is welcome, and esp. working fixes after deep reverse-engineering insights! |
|
@gzotti I have to ask... are Qt5 versions still being built because there are issues with Qt6 builds? If that's the case then the "withdrawing to obsolete versions at the slightest hint of a problem" is baked into the current deployment strategy. If that's not the case what is the reasoning behind both Qt5 and Qt6 builds/distributions? |
|
Qt5 builds are required on older systems:
It seems many observers use such oldish, otherwise obsolete systems to drive their telescopes, or they are in regions of this planet where PCs don't rain from the sky, and even old, used PCs are a major investment. A 2008 PC with Win10 (works in most cases!) and ANGLE is still better than no PC. Qt5 based releases for Windows should IMHO be provided as long as Win10 is widely used (i.e., at least V25.4), and as long as the code differences are miniscule. On Linux, some LTS distros may still have no Qt6. And who knows what will happen when probably hundreds of millions systems will (at least officially) have to move from Win10 to Linux in late 2025? After release of 1.0 reports about issues with the TC plugin came in. About every report that included version number indicated Qt6, which is why we recommend using Qt5-based builds (but not obsolete 0.21 builds!). This most likely indicates I messed up something while porting to Qt6, but was not able to identify what. People complained in some astro forums instead of reporting with us, and often declared to have reverted to older versions. |
What is this? Do you mean Pentium Pro, with the P6 microarchitecture? This won't even run Windows 7. Pentium 4? This one is usable with a discrete GPU.
They are irrelevant, their official Stellarium packages won't be upgraded anyway until OS release upgrade.
No one will have, just as many haven't moved from Windows 7 to anything, because at least this may bring problems with driver support. |
Whatever, maybe my memory fails with all these CPU names. A year ago I was asked for help with an older sub-Core-i laptop. I installed Win10, and Stellarium 0.22.1 worked in ANGLE mode. The thing serves the daily needs of an older gentleman. Then maybe it was Pentium-IV. Already then I associated "Pentium" with the 1990s. Now they seem to also call Atoms "Pentium". And I admit, I will never learn their "Lakes". EDIT: It was likely a P6000. Now, fit a discrete GPU into such an old laptop!
We provide Ubuntu packages for 18.04LTS. Does it have Qt6?
Requote: "(at least officially)" |
Sorry, but no, we do not provide packages for Ubuntu 18.04 LTS |
|
I was referring to https://launchpad.net/~stellarium/+archive/ubuntu/stellarium-releases I have two Odroid SBCs which are stuck with 18.04LTS. On these I like to have the latest features available, but can only build with Qt5. I hope I could still point out: being able to build with Qt5 (even without OS package manager support) will be needed for a few more years. |
alex-w
added
the
state: published
|
Hello @A-j-K! Please check the fresh version (development snapshot) of Stellarium: |
Installed Qt6 version snapshot stellarium-23.2-a69d242-qt6-win64.exe The serial port works perfectly now (didn't before with release Qt6) Tested with a SkyWatcher SynScan Pro Hand Controller and AZ-GTiX mount. |
Installed Qt5 version snapshot stellarium-23.2-a69d242-qt5-win64.exe The serial port works perfectly but it did before with a release Qt5. Tested with a SkyWatcher SynScan Pro Hand Controller and AZ-GTiX mount. |
Isn't 5.12 End-of-Life (as of December 2021) and 5.15 is LTS? |
We follow actual use in the OS distributions. E.g. in Ubuntu 20.04 LTS (which is supported till 2025) Qt 5.12 is still in use. |
alex-w
removed
the
state: published
|
Hello @A-j-K! Please check the latest stable version of Stellarium: |
Description
Qt6 appears to have introduced Unicode compilations. Type casting is insufficient and a full byte conversion is required.
Fixes #2934
Screenshots (if appropriate):
N/A
Type of change
How Has This Been Tested?
This was tested using my SkyWatcher SynScan Handcontroller AZ-GTiX Mount.
Note, this fix was at the serial port level and therefore I believe will address any mount that uses a serial port and not just my own SkyWatcher mount.
Test Configuration:
Checklist: