Skip to content

Commit

Permalink
benchmark: fix benchmark for file path and URL conversion
Browse files Browse the repository at this point in the history
PR-URL: nodejs#54190
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
EarlyRiser42 authored Aug 25, 2024
1 parent 52322aa commit 43f699d
Showing 1 changed file with 37 additions and 19 deletions.
56 changes: 37 additions & 19 deletions benchmark/url/whatwg-url-to-and-from-path.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,46 @@ const common = require('../common.js');
const { fileURLToPath, pathToFileURL } = require('node:url');
const isWindows = process.platform === 'win32';

const bench = common.createBenchmark(main, {
input: isWindows ? [
'file:///c/',
] : [
'file:///dev/null',
'file:///dev/null?key=param&bool',
'file:///dev/null?key=param&bool#hash',
],
method: isWindows ? [
'fileURLToPath',
] : [
'fileURLToPath',
'pathToFileURL',
],
n: [5e6],
});
const inputs = isWindows ? [
'C:\\foo',
'C:\\Program Files\\Music\\Web Sys\\main.html?REQUEST=RADIO',
'\\\\nas\\My Docs\\File.doc',
'\\\\?\\UNC\\server\\share\\folder\\file.txt',
'file:///C:/foo',
'file:///C:/dir/foo?query=1',
'file:///C:/dir/foo#fragment',
] : [
'/dev/null',
'/dev/null?key=param&bool',
'/dev/null?key=param&bool#hash',
'file:///dev/null',
'file:///dev/null?key=param&bool',
'file:///dev/null?key=param&bool#hash',
];

function main({ n, input, method }) {
method = method === 'fileURLOrPath' ? fileURLToPath : pathToFileURL;
const bench = common.createBenchmark(
main,
{
method: ['pathToFileURL', 'fileURLToPath'],
input: Object.values(inputs),
n: [5e6],
},
{
combinationFilter: (p) => (
(isWindows ?
(!p.input.startsWith('file://') && p.method === 'pathToFileURL') :
p.method === 'pathToFileURL'
) ||
(p.input.startsWith('file://') && p.method === 'fileURLToPath')
),
},
);

function main({ method, input, n }) {
const methodFunc = method === 'fileURLToPath' ? fileURLToPath : pathToFileURL;
bench.start();
for (let i = 0; i < n; i++) {
method(input);
methodFunc(input);
}
bench.end(n);
}

0 comments on commit 43f699d

Please sign in to comment.