Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show HEX Modbus addresses too in the logs #495

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

virtualdj
Copy link
Contributor

This change allows to see the Modbus addresses in hex format too in the logs, so you can more easily spot errors in the inverter YAML definition file (which normally uses register addresses in hex format).

The log entries will change from this:

2024-01-21 13:31:31.174 WARNING (SyncWorker_1) [custom_components.solarman.solarman] Querying [1028-1051] failed with exception [Empty: ]

To this:

2024-01-21 13:31:31.174 WARNING (SyncWorker_1) [custom_components.solarman.solarman] Querying [1028-1051 (0x0404-0x041B)] failed with exception [Empty: ]

@StephanJoubert StephanJoubert merged commit 1eb4077 into StephanJoubert:main Feb 26, 2024
2 checks passed
@virtualdj virtualdj deleted the feat-hex-addresses branch February 26, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants