Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if the NSJ converters are correct #120

Closed
SteveDunn opened this issue Apr 26, 2022 · 0 comments
Closed

See if the NSJ converters are correct #120

SteveDunn opened this issue Apr 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@SteveDunn
Copy link
Owner

Describe the feature

We have code like:

 public override object ReadJson(Newtonsoft.Json.JsonReader reader, System.Type objectType, object existingValue, Newtonsoft.Json.JsonSerializer serializer)
            {
                var result = serializer.Deserialize<int?>(reader);
                return result.HasValue ? VOTYPE.From(result.Value) : null;
            }

in \src\Vogen\Templates\Double\Double_NewtonsoftJsonConverter.cs

I would expect to see Deserialize<double?>(reader);

@SteveDunn SteveDunn added the enhancement New feature or request label Apr 26, 2022
SteveDunn added a commit that referenced this issue Apr 30, 2022
Fixes #120 - JSON converters lose accuracy for float/decimal/double
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant