Issue 31 no new from functions or methods

src/Vogen/CreationUsingImplicitNewAnalyzer.cs

@@ -52,6 +52,36 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
             };
         }
 
+        ancestor = syntax.Ancestors(false)
+            .FirstOrDefault(a => a.IsKind(SyntaxKind.MethodDeclaration));
+
+        if (ancestor is MethodDeclarationSyntax methodSyntax)
+        {
+            TypeSyntax t = methodSyntax.ReturnType;
+            INamedTypeSymbol? voClass = VoFilter.TryGetValueObjectClass(ctx, t);
+
+            return voClass == null ? null : new FoundItem
+            {
+                VoClass = voClass,
+                Location = t.GetLocation()
+            };
+        }
+
+        ancestor = syntax.Ancestors(false)
+            .FirstOrDefault(a => a.IsKind(SyntaxKind.LocalFunctionStatement));
+
+        if (ancestor is LocalFunctionStatementSyntax localFunctionStatementSyntax)
+        {
+            TypeSyntax t = localFunctionStatementSyntax.ReturnType;
+            INamedTypeSymbol? voClass = VoFilter.TryGetValueObjectClass(ctx, t);
+
+            return voClass == null ? null : new FoundItem
+            {
+                VoClass = voClass,
+                Location = t.GetLocation()
+            };
+        }
+
         return null;
     }
 

tests/Testbench/Program.cs

@@ -9,14 +9,14 @@
 
 using Vogen;
 
-// var c =Foo.GetCustomer();
+var c = GetCustomer();
+CustomerId GetCustomer() => CustomerId.From(123);
 
 Console.ReadLine();
 
 [ValueObject(typeof(int))]
 public partial struct CustomerId { }
 
-class Foo  {
-    // public static CustomerId GetCustomer() => default;
-}
+
+
 

tests/Vogen.IntegrationTests/SnapshotTests/DisallowNewTests.cs

@@ -65,5 +65,108 @@ public partial struct CustomerId
         diagnostic.ToString().Should().Be("(10,1): error VOG010: Type 'CustomerId' cannot be constructed with 'new' as it is prohibited.");
     }
 
+    [Fact]
+    public void No_creation_using_implicit_new_from_method()
+    {
+        // The source code to test
+        var source = @"using Vogen;
+
+var c =Foo.GetCustomer();
+
+Console.ReadLine();
+
+[ValueObject(typeof(int))]
+public partial struct CustomerId { }
+
+class Foo  {
+    public static CustomerId GetCustomer() => new();
+}
+
+";
+
+        var (diagnostics, _) = TestHelper.GetGeneratedOutput<CreationUsingImplicitNewAnalyzer>(source);
+
+        diagnostics.Should().HaveCount(1);
+        Diagnostic diagnostic = diagnostics.Single();
+
+        diagnostic.Id.Should().Be("VOG010");
+        diagnostic.ToString().Should().Be("(11,19): error VOG010: Type 'CustomerId' cannot be constructed with 'new' as it is prohibited.");
+    }
+
+    [Fact]
+    public void Disallow_new_from_method()
+    {
+        // The source code to test
+        var source = @"using Vogen;
+
+var c =Foo.GetCustomer();
+
+Console.ReadLine();
+
+[ValueObject(typeof(int))]
+public partial struct CustomerId { }
+
+class Foo  {
+    public static CustomerId GetCustomer() => new CustomerId();
+}
+
+";
+
+        var (diagnostics, _) = TestHelper.GetGeneratedOutput<CreationUsingNewAnalyzer>(source);
+
+        diagnostics.Should().HaveCount(1);
+        Diagnostic diagnostic = diagnostics.Single();
+
+        diagnostic.Id.Should().Be("VOG010");
+        diagnostic.ToString().Should().Be("(11,51): error VOG010: Type 'CustomerId' cannot be constructed with 'new' as it is prohibited.");
+    }
+
+    [Fact]
+    public void Disallow_implicit_new_from_local_function()
+    {
+        // The source code to test
+        var source = @"using Vogen;
+
+var c = GetCustomer();
+CustomerId GetCustomer() => new();
+
+Console.ReadLine();
+
+[ValueObject(typeof(int))]
+public partial struct CustomerId { }
+";
+
+        var (diagnostics, _) = TestHelper.GetGeneratedOutput<CreationUsingImplicitNewAnalyzer>(source);
+
+        diagnostics.Should().HaveCount(1);
+        Diagnostic diagnostic = diagnostics.Single();
+
+        diagnostic.Id.Should().Be("VOG010");
+        diagnostic.ToString().Should().Be("(4,1): error VOG010: Type 'CustomerId' cannot be constructed with 'new' as it is prohibited.");
+    }
+
+    [Fact]
+    public void Disallow_new_from_local_function()
+    {
+        // The source code to test
+        var source = @"using Vogen;
+
+var c = GetCustomer();
+CustomerId GetCustomer() => new CustomerId();
+
+Console.ReadLine();
+
+[ValueObject(typeof(int))]
+public partial struct CustomerId { }
+";
+
+        var (diagnostics, _) = TestHelper.GetGeneratedOutput<CreationUsingNewAnalyzer>(source);
+
+        diagnostics.Should().HaveCount(1);
+        Diagnostic diagnostic = diagnostics.Single();
+
+        diagnostic.Id.Should().Be("VOG010");
+        diagnostic.ToString().Should().Be("(4,33): error VOG010: Type 'CustomerId' cannot be constructed with 'new' as it is prohibited.");
+    }
 
 }