Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Data property to validation so the exception thrown will co… #375

Merged
merged 6 commits into from
Mar 28, 2023

Conversation

sirphilliptubell
Copy link

Adding the ability to include specific validation data in the thrown exception.

src/Vogen/Util.cs Outdated Show resolved Hide resolved
…signing Data values to the Exception.

* Also fixed unit tests
@sirphilliptubell
Copy link
Author

sirphilliptubell commented Mar 20, 2023

Fixed the value assignment problem and the unit tests. I left the setter on the Data property as private for now, I'm not sure that people would want to set that.

Unit tests should pass, two still failed locally but they looked like they were due to the time zone I'm in.

@SteveDunn
Copy link
Owner

Fixed the value assignment problem and the unit tests. I left the setter on the Data property as private for now, I'm not sure that people would want to set that.

Unit tests should pass, two still failed locally but they looked like they were due to the time zone I'm in.

Great - thanks very much for contributing! I'd really appreciate any help with the failed timezone tests - I can't get it into a state to reproduce!

Copy link
Owner

@SteveDunn SteveDunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks very much for the PR - much appreciated! 👍

@sirphilliptubell
Copy link
Author

sirphilliptubell commented Mar 28, 2023

I added a fix that I think should fix the unit test that failed due to my timezone. At least it passes on my end. Thanks for updating those other verify files.

Also, is it normal that when you run build.ps1 that it takes over an hour for this to run?

Passed!  - Failed:     0, Passed:  9295, Skipped:     8, Total:  9303, Duration: 1 h 25 m - SnapshotTests.dll (net6.0)
...
Passed!  - Failed:     0, Passed:  9303, Skipped:     0, Total:  9303, Duration: 19 m 5 s - SnapshotTests.dll (net7.0)

@SteveDunn SteveDunn merged commit bcd29e9 into SteveDunn:main Mar 28, 2023
@sirphilliptubell
Copy link
Author

Thanks again for this awesome library, just found it recently and I'll definitely be using it a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants