-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Data property to validation so the exception thrown will co… #375
Conversation
…signing Data values to the Exception. * Also fixed unit tests
Fixed the value assignment problem and the unit tests. I left the setter on the Data property as private for now, I'm not sure that people would want to set that. Unit tests should pass, two still failed locally but they looked like they were due to the time zone I'm in. |
Great - thanks very much for contributing! I'd really appreciate any help with the failed timezone tests - I can't get it into a state to reproduce! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks very much for the PR - much appreciated! 👍
I added a fix that I think should fix the unit test that failed due to my timezone. At least it passes on my end. Thanks for updating those other verify files. Also, is it normal that when you run build.ps1 that it takes over an hour for this to run?
|
Thanks again for this awesome library, just found it recently and I'll definitely be using it a lot. |
Adding the ability to include specific validation data in the thrown exception.